-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding --system option to pip (Linux Mint problem) #836
Changes from 2 commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -447,7 +447,7 @@ def run_pip(self): | |
text area. | ||
""" | ||
package = self.to_add.pop() | ||
args = ['-m', 'pip', 'install', package, '--target', | ||
args = ['-m', 'pip', 'install', package, '--system', '--target', | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Based on pypa/pip#3826 it sounds like this is a debian specific flag patched into pip, is that right?
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Look at: maybe... f.readlines() ['DISTRIB_ID=LinuxMint\n', There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But do we understand the original problem? Perhaps there is a different workaround or fix. The issue linked inside #822 is about mixing the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As I investigated the problem, in Debian's based distros the only way to install libs using pip in users directory (via There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. But the Based on your error output in #822 it looks like the problem here could be that somehow the final command executed includes both the flags
In this case the However, if this is the case, where is the There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Hi, I manage to find a pip.conf file inside .pip folder in my home directory. It has a parameter "user=true" in it. When I changed this parameter to false, I could finally use the -t option on pip. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good find @Saziba! |
||
self.module_dir] | ||
self.process = QProcess(self) | ||
self.process.setProcessChannelMode(QProcess.MergedChannels) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reduce the diff it would be good to revert this change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'am trying, I'm not a git master ;-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have made revert - 2eaba0f
But I do not know what to do next. When I do pull request I see:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's good, the final diff is only the new flag stuff, so we can always merge and squash to have compress all the final changes into a single commit.