Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug when setting lower and upper bounds in a specific order #72

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sreid768
Copy link

I've added a quick if-statement to detect if the lower bounds will be less than _minimumValue as a result of setting lowerValue before upperValue.

I've added a quick if-statement to detect if the lower bounds will be less than _minimumValue as a result of setting lowerValue before upperValue.
@markusfassbender
Copy link

Thanks, looks good.
To improve the code readability i would suggest to create a new variable with a meaningful name for MIN(value, _upperValue - _minimumRange) ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants