Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent override global URL when environment is not client #667

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

midori0507
Copy link

@midori0507 midori0507 commented Aug 17, 2020

Will temporarily fix issue on #666

URL namespace is always available in server side (Nodejs) as well as client-side.
In client, it will resolve to window.URL

In case it's undefined. The fallback code can do its job.

@Heedster
Copy link

Heedster commented Oct 11, 2020

@muaz-khan Can you get this merged? Would be really helpful.

@romannick
Copy link

@muaz-khan, can this please be addressed?

@jamauro
Copy link

jamauro commented Aug 6, 2021

Please merge. I just ran into this issue as well.

@SahilMahadwar
Copy link

Hey please fix this I just ran into this issue as well.

@brycedbjork
Copy link

To get RecordRTC and StereoAudioRecorder working with NextJS, I had to apply these the changes in this PR using patch-package. Would be great to get these merged into master

@j0hnm4r5
Copy link

j0hnm4r5 commented Aug 1, 2023

@muaz-khan can you merge this?

@KitsonBroadhurst
Copy link

Ran into this issue too with NExtJS. Is this package no longer maintained?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants