Skip to content

Commit

Permalink
[ButtonBase] Revert to the pre-unstyled implementation (#28225)
Browse files Browse the repository at this point in the history
  • Loading branch information
michaldudak committed Sep 13, 2021
1 parent 4b70971 commit 161b7b1
Showing 1 changed file with 205 additions and 22 deletions.
227 changes: 205 additions & 22 deletions packages/mui-material/src/ButtonBase/ButtonBase.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,14 @@ import * as React from 'react';
import PropTypes from 'prop-types';
import clsx from 'clsx';
import { elementTypeAcceptingRef, refType } from '@mui/utils';
import { useButton } from '@mui/core/ButtonUnstyled';
import composeClasses from '@mui/core/composeClasses';
import styled from '../styles/styled';
import useThemeProps from '../styles/useThemeProps';
import useForkRef from '../utils/useForkRef';
import useEventCallback from '../utils/useEventCallback';
import useIsFocusVisible from '../utils/useIsFocusVisible';
import TouchRipple from './TouchRipple';
import buttonBaseClasses, { getButtonBaseUtilityClass } from './buttonBaseClasses';
import useTouchRipple from '../useTouchRipple';

const useUtilityClasses = (ownerState) => {
const { disabled, focusVisible, focusVisibleClassName, classes } = ownerState;
Expand Down Expand Up @@ -105,22 +105,20 @@ const ButtonBase = React.forwardRef(function ButtonBase(inProps, ref) {
} = props;

const buttonRef = React.useRef(null);
const handleRef = useForkRef(buttonRef, ref);

const rippleRef = React.useRef(null);

let ComponentProp = component;

if (ComponentProp === 'button' && (other.href || other.to)) {
ComponentProp = LinkComponent;
const {
isFocusVisibleRef,
onFocus: handleFocusVisible,
onBlur: handleBlurVisible,
ref: focusVisibleRef,
} = useIsFocusVisible();
const [focusVisible, setFocusVisible] = React.useState(false);
if (disabled && focusVisible) {
setFocusVisible(false);
}

const { focusVisible, setFocusVisible, getRootProps } = useButton({
...props,
component: ComponentProp,
ref: handleRef,
});

React.useImperativeHandle(
action,
() => ({
Expand All @@ -129,18 +127,187 @@ const ButtonBase = React.forwardRef(function ButtonBase(inProps, ref) {
buttonRef.current.focus();
},
}),
[setFocusVisible],
[],
);

const { enableTouchRipple, getRippleHandlers } = useTouchRipple({
disabled,
disableFocusRipple: !focusRipple,
disableRipple,
disableTouchRipple,
focusVisible,
rippleRef,
React.useEffect(() => {
if (focusVisible && focusRipple && !disableRipple) {
rippleRef.current.pulsate();
}
}, [disableRipple, focusRipple, focusVisible]);

function useRippleHandler(rippleAction, eventCallback, skipRippleAction = disableTouchRipple) {
return useEventCallback((event) => {
if (eventCallback) {
eventCallback(event);
}

const ignore = skipRippleAction;
if (!ignore && rippleRef.current) {
rippleRef.current[rippleAction](event);
}

return true;
});
}

const handleMouseDown = useRippleHandler('start', onMouseDown);
const handleContextMenu = useRippleHandler('stop', onContextMenu);
const handleDragLeave = useRippleHandler('stop', onDragLeave);
const handleMouseUp = useRippleHandler('stop', onMouseUp);
const handleMouseLeave = useRippleHandler('stop', (event) => {
if (focusVisible) {
event.preventDefault();
}
if (onMouseLeave) {
onMouseLeave(event);
}
});
const handleTouchStart = useRippleHandler('start', onTouchStart);
const handleTouchEnd = useRippleHandler('stop', onTouchEnd);
const handleTouchMove = useRippleHandler('stop', onTouchMove);

const handleBlur = useRippleHandler(
'stop',
(event) => {
handleBlurVisible(event);
if (isFocusVisibleRef.current === false) {
setFocusVisible(false);
}
if (onBlur) {
onBlur(event);
}
},
false,
);

const handleFocus = useEventCallback((event) => {
// Fix for https://github.com/facebook/react/issues/7769
if (!buttonRef.current) {
buttonRef.current = event.currentTarget;
}

handleFocusVisible(event);
if (isFocusVisibleRef.current === true) {
setFocusVisible(true);

if (onFocusVisible) {
onFocusVisible(event);
}
}

if (onFocus) {
onFocus(event);
}
});

const isNonNativeButton = () => {
const button = buttonRef.current;
return component && component !== 'button' && !(button.tagName === 'A' && button.href);
};

/**
* IE11 shim for https://developer.mozilla.org/en-US/docs/Web/API/KeyboardEvent/repeat
*/
const keydownRef = React.useRef(false);
const handleKeyDown = useEventCallback((event) => {
// Check if key is already down to avoid repeats being counted as multiple activations
if (
focusRipple &&
!keydownRef.current &&
focusVisible &&
rippleRef.current &&
event.key === ' '
) {
keydownRef.current = true;
rippleRef.current.stop(event, () => {
rippleRef.current.start(event);
});
}

if (event.target === event.currentTarget && isNonNativeButton() && event.key === ' ') {
event.preventDefault();
}

if (onKeyDown) {
onKeyDown(event);
}

// Keyboard accessibility for non interactive elements
if (
event.target === event.currentTarget &&
isNonNativeButton() &&
event.key === 'Enter' &&
!disabled
) {
event.preventDefault();
if (onClick) {
onClick(event);
}
}
});

const handleKeyUp = useEventCallback((event) => {
// calling preventDefault in keyUp on a <button> will not dispatch a click event if Space is pressed
// https://codesandbox.io/s/button-keyup-preventdefault-dn7f0
if (
focusRipple &&
event.key === ' ' &&
rippleRef.current &&
focusVisible &&
!event.defaultPrevented
) {
keydownRef.current = false;
rippleRef.current.stop(event, () => {
rippleRef.current.pulsate(event);
});
}
if (onKeyUp) {
onKeyUp(event);
}

// Keyboard accessibility for non interactive elements
if (
onClick &&
event.target === event.currentTarget &&
isNonNativeButton() &&
event.key === ' ' &&
!event.defaultPrevented
) {
onClick(event);
}
});

let ComponentProp = component;

if (ComponentProp === 'button' && (other.href || other.to)) {
ComponentProp = LinkComponent;
}

const buttonProps = {};
if (ComponentProp === 'button') {
buttonProps.type = type === undefined ? 'button' : type;
buttonProps.disabled = disabled;
} else {
if (!other.href && !other.to) {
buttonProps.role = 'button';
}
if (disabled) {
buttonProps['aria-disabled'] = disabled;
}
}

const handleOwnRef = useForkRef(focusVisibleRef, buttonRef);
const handleRef = useForkRef(ref, handleOwnRef);

const [mountedState, setMountedState] = React.useState(false);

React.useEffect(() => {
setMountedState(true);
}, []);

const enableTouchRipple = mountedState && !disableRipple && !disabled;

if (process.env.NODE_ENV !== 'production') {
// eslint-disable-next-line react-hooks/rules-of-hooks
React.useEffect(() => {
Expand Down Expand Up @@ -174,7 +341,23 @@ const ButtonBase = React.forwardRef(function ButtonBase(inProps, ref) {
as={ComponentProp}
className={clsx(classes.root, className)}
ownerState={ownerState}
{...getRootProps(getRippleHandlers(props))}
onBlur={handleBlur}
onClick={onClick}
onContextMenu={handleContextMenu}
onFocus={handleFocus}
onKeyDown={handleKeyDown}
onKeyUp={handleKeyUp}
onMouseDown={handleMouseDown}
onMouseLeave={handleMouseLeave}
onMouseUp={handleMouseUp}
onDragLeave={handleDragLeave}
onTouchEnd={handleTouchEnd}
onTouchMove={handleTouchMove}
onTouchStart={handleTouchStart}
ref={handleRef}
tabIndex={disabled ? -1 : tabIndex}
type={type}
{...buttonProps}
{...other}
>
{children}
Expand Down

0 comments on commit 161b7b1

Please sign in to comment.