Skip to content

Commit

Permalink
zeeshan review
Browse files Browse the repository at this point in the history
  • Loading branch information
sai6855 committed Mar 13, 2024
1 parent db9554d commit 5b1a414
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
2 changes: 1 addition & 1 deletion packages/mui-material/src/Select/Select.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -148,7 +148,7 @@ export interface BaseSelectProps<Value = unknown>
* The variant to use.
* @default 'outlined'
*/
variant?: 'filled' | 'standard' | 'outlined';
variant?: SelectVariants;
}

export interface FilledSelectProps extends Omit<FilledInputProps, 'value' | 'onChange'> {
Expand Down
7 changes: 2 additions & 5 deletions packages/mui-material/src/Select/Select.spec.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -132,13 +132,10 @@ function genericValueTest() {
otherProp?: number;
}

const SelectWrapper1 = <Value = unknown,>(props: SelectProps<Value> & OtherProps) => {
const SelectWrapper1 = <Value,>(props: SelectProps<Value> & OtherProps) => {
const { otherProp, ...materialSelectProps } = props;

return (
// how to solve this:
<Select<Value> {...materialSelectProps} />
);
return <Select<Value> {...materialSelectProps} />;
};

<SelectWrapper1 />;
Expand Down

0 comments on commit 5b1a414

Please sign in to comment.