[core] Batch small changes (#21335)

mui · Jun 7, 2020 · 74d85f5 · 74d85f5
1 parent f9b581e
commit 74d85f5
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 14 deletions.
diff --git a/docs/src/pages/components/material-icons/SearchIcons.js b/docs/src/pages/components/material-icons/SearchIcons.js
@@ -107,6 +107,9 @@ let Icons = (props) => {
               onClick={handleClickOpen}
               title={icon.key}
               className={classes.iconSvg}
+              data-ga-event-category="material-icons"
+              data-ga-event-action="click"
+              data-ga-event-label={icon.key}
             />
             {/* eslint-disable jsx-a11y/no-noninteractive-element-interactions, jsx-a11y/click-events-have-key-events */}
             <p onClick={handleClick}>{icon.key}</p>
@@ -421,8 +424,8 @@ export default function SearchIcons() {
               window.ga('send', {
                 hitType: 'event',
                 eventCategory: 'material-icons',
-                eventAction: value,
-                eventLabel: 'no results',
+                eventAction: 'no-results',
+                eventLabel: value,
               });
             }
           });

diff --git a/packages/material-ui/src/Popper/Popper.test.js b/packages/material-ui/src/Popper/Popper.test.js
@@ -52,7 +52,7 @@ describe('<Popper />', () => {
           </Popper>
         </ThemeProvider>,
       );
-      expect(renderSpy.callCount).to.equal(2); // 2 for strict mode
+      expect(renderSpy.callCount).to.equal(2); // strict mode renders twice
       expect(renderSpy.args[0][0]).to.equal('top');
     });
 

diff --git a/packages/material-ui/src/Select/Select.test.js b/packages/material-ui/src/Select/Select.test.js
@@ -215,16 +215,6 @@ describe('<Select />', () => {
   });
 
   describe('prop: onChange', () => {
-    let clock;
-
-    before(() => {
-      clock = useFakeTimers();
-    });
-
-    after(() => {
-      clock.restore();
-    });
-
     it('should get selected element from arguments', () => {
       const onChangeHandler = spy();
       const { getAllByRole, getByRole } = render(
@@ -1024,7 +1014,7 @@ describe('<Select />', () => {
     expect(getByRole('button')).to.have.text('France');
   });
 
-  it('should support native from validation', function test() {
+  it('should support native form validation', function test() {
     if (/jsdom/.test(window.navigator.userAgent)) {
       // see https://github.com/jsdom/jsdom/issues/123
       this.skip();