Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(docs) Browserify throws an error if components' code is updated #655

Closed
pomerantsev opened this issue May 18, 2015 · 1 comment · Fixed by #656
Closed

(docs) Browserify throws an error if components' code is updated #655

pomerantsev opened this issue May 18, 2015 · 1 comment · Fixed by #656
Labels
docs Improvements or additions to the documentation

Comments

@pomerantsev
Copy link
Contributor

To reproduce:

  • run gulp in the docs directory.
  • change any of the material-ui components source files (not the docs source files) and save it.
    I always see an error. This is probably due to how browserify is configured.
pomerantsev added a commit to pomerantsev/material-ui that referenced this issue May 18, 2015
@pomerantsev
Clean up code, make rebuilding docs site easier, and make it possible…
e256654 
… to use all ES6 features

Fixes mui#655, mui#606, mui#440, mui#392.

Goals of this PR:
- being able to use all ES6 features (with babel)
- adding JSHint and cleaning up most obvious mistakes in code
- making it so that browserify doesn't throw an error when components'
  code changes while watching files
- minor cleanup of the dependencies in package.json files
@pomerantsev pomerantsev mentioned this issue May 18, 2015
Merged
@jkruder
Copy link
Contributor

jkruder commented May 19, 2015

I ran into this same issue and resolved it by installing the minimum version of all of the gulp* modules. There's some clashing between later versions of the gulp* modules.

@oliviertassinari oliviertassinari added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Dec 25, 2022
@zannager zannager added docs Improvements or additions to the documentation and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jan 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
4 participants
@jkruder @oliviertassinari @pomerantsev @zannager