Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Roadmap #2403

Merged
merged 6 commits into from
Dec 15, 2015
Merged

Roadmap #2403

merged 6 commits into from
Dec 15, 2015

Conversation

alitaheri
Copy link
Member

@oliviertassinari Is this ok? also check the line I added in the README.md.

@oliviertassinari
Copy link
Member

Nice! I will let @shaurya947 merge if he is ok with it.

@oliviertassinari
Copy link
Member

I think that you could add another future :

  • improve performances with shouldComponentUpdate and removed inefficient computation.

@shaurya947
Copy link
Contributor

@subjectix @oliviertassinari I commented on the gist and am generally ok with this. I'll have @hai-cea take a look before it is merged..

@alitaheri alitaheri modified the milestone: 0.14.0 Release Dec 9, 2015
@alitaheri alitaheri mentioned this pull request Dec 9, 2015
@mbrookes
Copy link
Member

Good to see this. As mentioned elsewhere, I believe standardising the API should be a roadmap item, both in terms of gaps in available API calls (where relevant), and API naming inconsistencies.

Perhaps when the autodocs are done you could generate a table of what api calls are available for what components? That would highlight where the gaps and inconsistencies are.

@alitaheri
Copy link
Member Author

@mbrookes Yeah we've had this issue in many places. I like your idea. I'm gonna update the roadmap.

@mbrookes
Copy link
Member

Thanks. Where possible it would also be good to standardise the callback parameter ordering for events etc. When developing formsy-material-ui I had to have different versions of effectively the same callback due to variations in the parameter order and response format between MUI form components. I know that will be harder than just renaming and aliasing deprecated function names, but worth it in the long run for reduced cognitive load and code simplicity (for the user).

@alitaheri
Copy link
Member Author

@mbrookes yup, that one is a real buzzkiller. But before we implement that, we should fix the docs so that callback signatures are formally documented.

@mbrookes
Copy link
Member

Agree completely, just wanted to throw it out there as a related point. All in good time. :)

Callbacks are becoming the first class citizens of material-ui, so, their signature must be formally documented.
@alitaheri
Copy link
Member Author

@mbrookes I added that to the list, thanks 👍

@hai-cea
Copy link
Member

hai-cea commented Dec 15, 2015

@subjectix I think this looks great! Thanks for pulling this together.

hai-cea added a commit that referenced this pull request Dec 15, 2015
@hai-cea hai-cea merged commit 5c8a39b into mui:master Dec 15, 2015
@alitaheri
Copy link
Member Author

@hai-cea Thank you 🎉 🎉

@zannager zannager added the docs Improvements or additions to the documentation label Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants