[core] Rename packages #28049

mnajdova · 2021-08-30T11:11:49Z

BREAKING CHANGE

The packages were renamed. Here is the mapping between the old and new names:

@material-ui/core -> @mui/material
@material-ui/system -> @mui/system
@material-ui/unstyled -> @mui/core
@material-ui/styles -> @mui/styles
@material-ui/icons -> @mui/icons-material
@material-ui/lab -> @mui/lab
@material-ui/types -> @mui/types
@material-ui/styled-engine -> @mui/styled-engine
@material-ui/styled-engine-sc ->@mui/styled-engine-sc
@material-ui/private-theming -> @mui/private-theming
@material-ui/codemod -> @mui/codemod
@material-ui/docs -> @mui/docs
@material-ui/envinfo -> @mui/envinfo

Step 2 of #27666

the PR does not do any changes in the folder structures
in the packages/material-ui-codemod for now I didn't do any replacements expect changing the name of the package from @material-ui/codemod to @mui/codemod. (it will be handled in a follow up PR by @siriwatknp)
there aren't any changes in the CHANGELOG files
there aren't any changes done regarding renaming of the data-grid packages

Things we need to resolve.

Is it ok that we renamed the @material-ui/styles -> @mui/styles package? ✅
~~Should the @material-ui/lab be renamed to @mui/lab or @mui/lab-material?~~
else?

mui-pr-bot · 2021-08-30T11:13:53Z

Details of bundle changes (experimental)

Generated by 🚫 dangerJS against 32d729a

michaldudak · 2021-08-30T11:27:32Z

🎉 Over 3600 changed files, you're going for the record :)

the PR does not do any changes in the folder structures

Do you intend to do a follow-up PR to rename the directories?

mnajdova · 2021-08-30T11:29:00Z

Do you intend to do a follow-up PR to rename the directories?

Yes, I think it will make sense, I just don't want to do any changes that are not necessary with his PR :D

mnajdova · 2021-08-30T11:40:54Z

Each rebase with the next will be fatal 😭

mnajdova · 2021-08-30T14:38:41Z

@mnajdova just realized about the lab. I think it is now @mui/lab but should it be @mui/material-lab because it is material design implementation?

Good question. I don't know, to be honest I think it's enough to have one lab package to test out new things, rather than creating a new one for each design system (but it may be problematic with the dependencies). I don't have strong preference, but maybe I would lean towards agreeing with you and renaming it to @mui/lab-material (I've added the material as a suffix to follow @mui/icons-material)

mnajdova · 2021-08-30T15:36:31Z

I can't believe I have a green build 😄 @mui-org/core please have a look. Also, we need to decide on the two open questions from the PR description. I would recommend reviewing per commit (probably it's the only way possible)

eps1lon · 2021-08-31T07:58:59Z

Would like to wait for #28060 and see how #28060 fares against our own code base.

This would help reviewability. And I want to make sure the bundle tracking works across package rename. So holding this until #28060 is merged.

mnajdova · 2021-08-31T12:17:10Z

Would like to wait for #28060 and see how #28060 fares against our own code base.

This would help reviewability. And I want to make sure the bundle tracking works across package rename. So holding this until #28060 is merged.

@eps1lon I just approved #28060, looks like all comments were resolved. Should I merge it and rebase this one?

How should we handle the bundle size?

eps1lon · 2021-08-31T13:46:25Z

The names in scripts/sizeSnapshot/webpack.config.js just need to stay the same. We can update the view later to avoid confusion.

mnajdova · 2021-08-31T14:11:27Z

The names in scripts/sizeSnapshot/webpack.config.js just need to stay the same. We can update the view later to avoid confusion.

Done with 390de56

@eps1lon looks like it fails now 😕 https://dev.azure.com/mui-org/Material-UI/_build/results?buildId=32546&view=logs&j=5ab4dc89-fdbd-5515-5007-71e9b3b221f6&t=865800ee-c958-58a0-9938-e205624d5850

eps1lon

bundling workflow failing is expected right now.
profile workflow is fine (same failures on next): https://app.circleci.com/pipelines/github/mui-org/material-ui/51561/workflows/ce073148-5f94-4651-9617-b73ff9b32131
benchmark workflow is green: https://dev.azure.com/mui-org/Material-UI/_build/results?buildId=32586&view=logs&jobId=9ef21fd1-5d60-5fa4-f8b2-6dc79e173863

Will revert the changes to translated markdown files (since they'll be invalidated anyway).

As a follow-up, I'll update the bundle size tracking view to display the new package names properly and follow up with some clearer documentation in size:snapshot.

```bash ~/D/p/m/fork (feat/rename-packages|✔) $ git co next -- '*-de.md' ~/D/p/m/fork (feat/rename-packages|●68) $ git co next -- '*-es.md' ~/D/p/m/fork (feat/rename-packages|●136) $ git co next -- '*-fr.md' ~/D/p/m/fork (feat/rename-packages|●202) $ git co next -- '*-ja.md' ~/D/p/m/fork (feat/rename-packages|●270) $ git co next -- '*-pt.md' ~/D/p/m/fork (feat/rename-packages|●339) $ git co next -- '*-ru.md' ~/D/p/m/fork (feat/rename-packages|●406) $ git co next -- '*-zh.md' ```

```bash ~/D/p/m/fork (feat/rename-packages|✔) $ git co next -- '*-de.json' ~/D/p/m/fork (feat/rename-packages|●1) $ git co next -- '*-es.json' ~/D/p/m/fork (feat/rename-packages|●2) $ git co next -- '*-fr.json' ~/D/p/m/fork (feat/rename-packages|●3) $ git co next -- '*-ja.json' ~/D/p/m/fork (feat/rename-packages|●4) $ git co next -- '*-pt.json' ~/D/p/m/fork (feat/rename-packages|●5) $ git co next -- '*-ru.json' ~/D/p/m/fork (feat/rename-packages|●6) $ git co next -- '*-zh.json' ~/D/p/m/fork (feat/rename-packages|●7) $ git co next -- '*-zh.json' ```

Jack-Works · 2021-09-12T03:58:22Z

Please add npm/yarn/pnpm alias as a possible migration way. I use the following command to defer the renaming work in our codebase.

$ pnpm add @material-ui/system@npm:@mui/system@5.0.0-rc.0 @material-ui/lab@npm:@mui/lab@5.0.0-alpha.45 @material-ui/core@npm:@mui/material@5.0.0-rc.0 @material-ui/icons@npm:@mui/icons-material@5.0.0-rc.0

Jack-Works · 2021-09-12T04:03:12Z

It also works for notistack

Jack-Works · 2021-09-12T04:04:58Z

In addition, I believe we will need to temporary disable the notistack example again, until it's updated to the new packages.

It did. iamhosseindhv/notistack#423 1.0.6-next.3

oliviertassinari · 2021-09-14T12:55:52Z

I have added the counterpart to these changes in the v4 migration guide with #27912. I believe it hasn't been done: https://next--material-ui.netlify.app/guides/migration-v4/.

mnajdova added 19 commits August 30, 2021 12:10

Replace @material-ui/core -> @mui/material

0c63e57

Replace @material-ui/system -> @mui/system

f1602cd

Replaced @material-ui/styled-engine -> @mui/styled-engine

d3de03f

Replace @material-ui/icons -> @mui/icons-material

9d80277

Revert CHANGELOG changes

40dbf84

Replace @material-ui/unstyled -> @mui/core

72bad83

Replace @material-ui/lab -> @mui/lab

f8bc440

Replace @material-ui/docs -> @mui/docs

380a464

Replace @material-ui/utils -> @mui/utils

4c12ef8

Replace @material-ui/private-theming -> @mui/private-theming

54d089f

Replace @material-ui/styles -> @mui/styles

39a82ff

Replace @material-ui/types -> @mui/types

9b9662a

Replace @material-ui/markdown -> @mui/markdown

bd50374

Misc @material-ui -> @mui replacements

53ff8bd

Misc @material-ui -> @mui replacements

b58448e

Revert data-grid package rename

bf7fee1

revert yarn.lock

7c7ebb3

Revert @material-ui/codemod changes

410b9f2

Replace @material-ui/codemod -> @mui/codemod

5027506

mnajdova changed the title ~~Feat/rename packages~~ [core] Rename packages Aug 30, 2021

mnajdova added the breaking change label Aug 30, 2021

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 30, 2021

mnajdova added 2 commits August 30, 2021 13:25

prettier & docs:typescript:formatted

e66b1ad

Merge branch 'next' into feat/rename-packages

b2da65e

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 30, 2021

Fix merge conflicts

e4a50ec

fix unit tests

32421e2

github-actions bot mentioned this pull request Aug 30, 2021

Update snapshots for pr/28049 eps1lon/mui-scripts-incubator#3013

Closed

mnajdova added 2 commits August 30, 2021 16:47

budnle size monitor fix

91c3888

Last fix I hope

1705efd

mnajdova marked this pull request as ready for review August 30, 2021 15:35

mnajdova requested a review from a team August 30, 2021 15:36

eps1lon added the on hold There is a blocker, we need to wait label Aug 31, 2021

oliviertassinari mentioned this pull request Aug 31, 2021

[codemod] Add mui-replace transform #28060

Merged

1 task

Revert changes in scripts/sizeSnapshot/webpack.config.js

390de56

mnajdova and others added 3 commits August 31, 2021 16:38

trigger build

ea21c7a

Merge branch 'next' into feat/rename-packages

dcc9173

Fix size:snapshot

5e731ab

eps1lon approved these changes Sep 1, 2021

View reviewed changes

eps1lon and others added 3 commits September 1, 2021 09:28

Merge branch 'next' into feat/rename-packages

32d729a

mnajdova removed the on hold There is a blocker, we need to wait label Sep 1, 2021

mnajdova merged commit 0979e6a into mui:next Sep 1, 2021

This was referenced Sep 8, 2021

Rename the packages #27666

Closed

Alert.js is importing withStyles from wrong file. #28259

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[core] Rename packages #28049

[core] Rename packages #28049

mnajdova commented Aug 30, 2021 •

edited

Loading

mui-pr-bot commented Aug 30, 2021 •

edited

Loading

michaldudak commented Aug 30, 2021

mnajdova commented Aug 30, 2021

mnajdova commented Aug 30, 2021

mnajdova commented Aug 30, 2021

mnajdova commented Aug 30, 2021

eps1lon commented Aug 31, 2021

mnajdova commented Aug 31, 2021 •

edited by oliviertassinari

Loading

eps1lon commented Aug 31, 2021

mnajdova commented Aug 31, 2021 •

edited

Loading

eps1lon left a comment

Jack-Works commented Sep 12, 2021

Jack-Works commented Sep 12, 2021

Jack-Works commented Sep 12, 2021

oliviertassinari commented Sep 14, 2021 •

edited

Loading

[core] Rename packages #28049

[core] Rename packages #28049

Conversation

mnajdova commented Aug 30, 2021 • edited Loading

mui-pr-bot commented Aug 30, 2021 • edited Loading

michaldudak commented Aug 30, 2021

mnajdova commented Aug 30, 2021

mnajdova commented Aug 30, 2021

mnajdova commented Aug 30, 2021

mnajdova commented Aug 30, 2021

eps1lon commented Aug 31, 2021

mnajdova commented Aug 31, 2021 • edited by oliviertassinari Loading

eps1lon commented Aug 31, 2021

mnajdova commented Aug 31, 2021 • edited Loading

eps1lon left a comment

Choose a reason for hiding this comment

Jack-Works commented Sep 12, 2021

Jack-Works commented Sep 12, 2021

Jack-Works commented Sep 12, 2021

oliviertassinari commented Sep 14, 2021 • edited Loading

mnajdova commented Aug 30, 2021 •

edited

Loading

mui-pr-bot commented Aug 30, 2021 •

edited

Loading

mnajdova commented Aug 31, 2021 •

edited by oliviertassinari

Loading

mnajdova commented Aug 31, 2021 •

edited

Loading

oliviertassinari commented Sep 14, 2021 •

edited

Loading