Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Don't use Material theme in unstyled demos #28073

Merged
merged 4 commits into from
Sep 8, 2021

Conversation

michaldudak
Copy link
Member

Removes the @material-ui/core imports from unstyled button demos.
Discussed in #27600 (comment)

@michaldudak michaldudak added the docs Improvements or additions to the documentation label Aug 31, 2021
@mui-pr-bot
Copy link

mui-pr-bot commented Aug 31, 2021

No bundle size changes (experimental)

Generated by 🚫 dangerJS against b677e23

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 1, 2021
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 1, 2021
@mnajdova
Copy link
Member

mnajdova commented Sep 1, 2021

I like the changes, especially that we are moving to CSS variables. Also, the code for the demo seem isolated from any design system that we may have, which is great for the unstyled demos.

I would maybe suggest changing the title of the PR, as the changes are more than just changing the imports :)

@michaldudak michaldudak changed the title [docs] Don't use Material imports in unstyled demos [docs] Don't use Material theme in unstyled demos Sep 2, 2021
@michaldudak
Copy link
Member Author

@oliviertassinari, @mnajdova are you ok with merging this?
Perhaps @danilo-leal or @siriwatknp would have anything to add?

Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A lot better! I think we also have an opportunity to display different styles leveraging the unstyled. We've already done this very nicely in the Switch customization section. This type of stuff has been very useful for me when I was in a position to consider different libraries and showcasing how different you can make it look definitely adds weight.

But just an idea for moving forward with promoting the unstyled. This is overall very good. Liked the CSS vars too!

@michaldudak michaldudak merged commit b74400d into mui:next Sep 8, 2021
@michaldudak michaldudak deleted the button-docs-improvements branch September 8, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants