-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Don't use Material theme in unstyled demos #28073
Conversation
I like the changes, especially that we are moving to CSS variables. Also, the code for the demo seem isolated from any design system that we may have, which is great for the unstyled demos. I would maybe suggest changing the title of the PR, as the changes are more than just changing the imports :) |
@oliviertassinari, @mnajdova are you ok with merging this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot better! I think we also have an opportunity to display different styles leveraging the unstyled. We've already done this very nicely in the Switch customization section. This type of stuff has been very useful for me when I was in a position to consider different libraries and showcasing how different you can make it look definitely adds weight.
But just an idea for moving forward with promoting the unstyled. This is overall very good. Liked the CSS vars too!
Removes the
@material-ui/core
imports from unstyled button demos.Discussed in #27600 (comment)