Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MobileStepper] Add support for CSS vars #32606

Merged
merged 3 commits into from
May 5, 2022
Merged

[MobileStepper] Add support for CSS vars #32606

merged 3 commits into from
May 5, 2022

Conversation

haneenmahd
Copy link
Contributor

@haneenmahd haneenmahd commented May 4, 2022

Add support for CSS variables for the
MobileStepper component (#32049).

Preview: https://deploy-preview-32606--material-ui.netlify.app/experiments/material-ui/mobile-stepper/

@mui-bot
Copy link

mui-bot commented May 4, 2022

Details of bundle changes

Generated by 🚫 dangerJS against 6d8f0e1

@vicasas vicasas added new feature New feature or request component: stepper This is the name of the generic UI component, not the React module! labels May 4, 2022
<Box>Mobile Stepper</Box>

<Box>
<MobileStepper
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update the demo to something more meaningful? For example by adding some of the demos from - https://mui.com/material-ui/react-stepper/#mobile-stepper

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated it ✅ !

Copy link
Member

@mnajdova mnajdova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes generally looks good, let's just improve the demo :)

@haneenmahd
Copy link
Contributor Author

haneenmahd commented May 4, 2022

The changes generally looks good, let's just improve the demo :)

Yeah, you're right 👍🏻 !

@siriwatknp siriwatknp merged commit f614491 into mui:master May 5, 2022
@haneenmahd haneenmahd deleted the css-vars-mobile-stepper branch May 5, 2022 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: stepper This is the name of the generic UI component, not the React module! new feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants