Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Joy] Add List documentation #33120

Merged
merged 51 commits into from
Jun 17, 2022
Merged

[Joy] Add List documentation #33120

merged 51 commits into from
Jun 17, 2022

Conversation

siriwatknp
Copy link
Member

@siriwatknp siriwatknp commented Jun 12, 2022

@siriwatknp siriwatknp added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy labels Jun 12, 2022
@mui-bot
Copy link

mui-bot commented Jun 12, 2022

Details of bundle changes

@mui/joy: parsed: +0.65% , gzip: +0.61%

Generated by 🚫 dangerJS against 70cbddf

@danilo-leal danilo-leal changed the title [Joy] Add react-list docs [Joy] Add List documentation Jun 14, 2022
@siriwatknp
Copy link
Member Author

siriwatknp commented Jun 14, 2022

@danilo-leal I am not sure if adding the border to all demos is a good idea because that's not the default look of the List. It might be confused.

Also, I feel that the previous version looks closer to the iOS settings screen

Before
Screen Shot 2565-06-14 at 14 26 20

After
Screen Shot 2565-06-14 at 14 27 12

@danilo-leal
Copy link
Contributor

Just pushed some changes sort of reverting the demo designs. I kept the previous styles only in examples that showcase more than one list at the same time, though. Let me know what you think!

@siriwatknp
Copy link
Member Author

Just pushed some changes sort of reverting the demo designs. I kept the previous styles only in examples that showcase more than one list at the same time, though. Let me know what you think!

Looks good to me now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants