Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Fix CssBaseline import in example code #33614

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

dd-ssc
Copy link
Contributor

@dd-ssc dd-ssc commented Jul 22, 2022

First code example on page uses
import { ThemeProvider, createTheme, CssBaseline } from '@mui/material/styles';
which fails with
export 'CssBaseline' (imported as 'CssBaseline') was not found in '@mui/material/styles' ... .

Presumably, CssBaseline was moved recently and the first code example was not updated correspondingly; last code example on page is fine.

Preview: https://deploy-preview-33614--material-ui.netlify.app/material-ui/customization/dark-mode/#dark-mode-by-default

First code example on page uses
  `import { ThemeProvider, createTheme, CssBaseline } from '@mui/material/styles';`
which fails with
  `export 'CssBaseline' (imported as 'CssBaseline') was not found in '@mui/material/styles' ... `.

Presumably, `CssBaseline` was moved recently and the first code example was not updated correspondingly; last code example on page is fine.
@mui-bot
Copy link

mui-bot commented Jul 22, 2022

No bundle size changes

Generated by 🚫 dangerJS against 678778c

@ZeeshanTamboli ZeeshanTamboli added the docs Improvements or additions to the documentation label Jul 22, 2022
@ZeeshanTamboli ZeeshanTamboli changed the title fix CssBaseline import in example code [docs] Fix CssBaseline import in example code Jul 22, 2022
@ZeeshanTamboli ZeeshanTamboli added the bug 🐛 Something doesn't work label Jul 22, 2022
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks for the first contribution.

@ZeeshanTamboli ZeeshanTamboli merged commit 394798b into mui:master Jul 22, 2022
daniel-rabe pushed a commit to daniel-rabe/material-ui that referenced this pull request Nov 29, 2022
fix CssBaseline import in example code

First code example on page uses
  `import { ThemeProvider, createTheme, CssBaseline } from '@mui/material/styles';`
which fails with
  `export 'CssBaseline' (imported as 'CssBaseline') was not found in '@mui/material/styles' ... `.

Presumably, `CssBaseline` was moved recently and the first code example was not updated correspondingly; last code example on page is fine.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants