-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add callouts about controlled vs uncontrolled components in Core docs #37849
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelsycamore
added
docs
Improvements or additions to the documentation
support: docs-feedback
Feedback from documentation page
labels
Jul 6, 2023
danilo-leal
approved these changes
Jul 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, great addition! I'm sure this will help many people!
I feel like #35352 could be a great use case for this. Similar to https://www.notion.so/help/synced-blocks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
docs
Improvements or additions to the documentation
support: docs-feedback
Feedback from documentation page
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Users consistently express confusion about our usage of the terms "controlled" vs "uncontrolled"—many developers seem to be unaware of this React concept.
This has been resolved in the X docs by adding a callout everywhere it comes up to direct readers to the official React documentation on the topic. This PR does the same for the Core docs.
I think I caught all instances where the concept is mentioned. (I imagine the community will tell us soon enough if I missed any!)