Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[code-infra] Fix and update bundling fixtures #43709

Draft
wants to merge 23 commits into
base: master
Choose a base branch
from
Draft

[code-infra] Fix and update bundling fixtures #43709

wants to merge 23 commits into from

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Sep 11, 2024 •
edited
Loading

Tried to use this when testing package layout changes but the instructions fail.

  • Make sure we call createFixture in a prestart script
  • Remove the useBuildFromSource script, we can now rely on pnpm and publishConfig.dir.
  • Update instructions
  • (experiment) CI can likely be more efficient. It's likely faster to just install everything and run the tests one-by-one than to spin up an instance for each fixture.

@Janpot Janpot added the scope: code-infra Specific to the core-infra product label Sep 11, 2024
@mui-bot
Copy link

mui-bot commented Sep 11, 2024 •
edited
Loading

Netlify deploy preview

https://deploy-preview-43709--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against 6fc8166

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 17, 2024
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
scope: code-infra Specific to the core-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Janpot @mui-bot