[icons][docs] Reduce Material Icon page size #43911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-43911--material-ui.netlify.app/ Bundle size report |
Janpot
approved these changes
Sep 29, 2024
There was a problem hiding this comment.
I wonder what the impact on React rendering time is. iirc that was the original goal of the change
Edit: realized I still had this experiment on a local branch, it looks like it could drastically reduce page size. Will need to clean it up a bit first though.
|
My guess was that 2,000 function calls (onClick handler creation + random) is cheaper than downloading and parsing HTML |
|
I have measured the overhead to be around 0.1ms. Moving forward with this, it looks simpler. |
|
👍 The price per extra kB on my network is about 0.3ms. So for 10kB it's roughly an order of magnitude difference. |
oliviertassinari
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
After
Not a big difference ~7% saving, but it helps, the page is big. This is flagged in https://app.ahrefs.com/site-audit/3992793/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2Csize%2CtimeToFirstByte%2CloadingTime%2Cdepth%2Ccompliant%2CincomingAllLinks%2Corigin¤t=27-09-2024T024913&filterId=709f929d4b01712e0ab256af7bad8fea&issueId=c64da874-d0f4-11e7-8ed1-001e67ed4656&sorting=-pageRating. Since we compet for SEO for this page, it makes sense to me, it's a quick-win.
Preview https://deploy-preview-43911--material-ui.netlify.app/material-ui/material-icons/
Help with #41126