Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CardHeader] Removed the unnecessary right padding #4746

Closed
wants to merge 1 commit into from

Conversation

aahan96
Copy link
Contributor

@aahan96 aahan96 commented Jul 19, 2016

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

Removed the unnecessary right padding from the title style. Doesn't affect desktop, but makes the title look a lot better on smaller screens. Closes #4695

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 19, 2016

@aahan96 I agree, this paddingRight is weird. It would be much better to rely on the browser layout engine.

What about long Card title?
capture d ecran 2016-07-19 a 22 32 09

@aahan96
Copy link
Contributor Author

aahan96 commented Jul 20, 2016

@oliviertassinari How about this? I think a Card Title shouldn't be that long. And if that is, it'll just be cut. Do you think we should continue with this approach?

screen shot 2016-07-20 at 2 50 51 pm

@oliviertassinari
Copy link
Member

oliviertassinari commented Jul 20, 2016

@aahan96 Have you tried on a smaller screen?

I think a Card Title shouldn't be that long

We have no idea how it's going to be used. We can't take that risk.

@oliviertassinari
Copy link
Member

oliviertassinari commented Aug 3, 2016

@aahan96 Any update on this PR? I see two ways to fix it:

  1. We take advantage of the flex-layout engin so we don't need to use the absolute positioning. However, that doesn't play well with old version of IE. We would have to drop the officially drop the support of those old versions. Hence, that something that I think would be better on the next branch.
  2. We inspect the children property and only apply this paddingRight: '90px' when one of the children is a <CardExpandable /> component.

@oliviertassinari oliviertassinari added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Aug 3, 2016
@oliviertassinari
Copy link
Member

I'm closing this PR. Feel free to reopen it with a proper solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants