Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Upgrade react-tap-event-plugin and react peer dependency #6057

Merged
merged 5 commits into from
Feb 4, 2017
Merged

[core] Upgrade react-tap-event-plugin and react peer dependency #6057

merged 5 commits into from
Feb 4, 2017

Conversation

rosskevin
Copy link
Member

@rosskevin rosskevin commented Feb 3, 2017

Fixes #5646

React 15.4 requires the minimum version for react-tap-event-plugin to be 2.0.1.

The restriction was a bit lenient previously (which would fail with react 15.4), so hopefully raising the restriction exposes any other conflicts that were previously hidden. The react version will be raised to 15.4 as well.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@rosskevin rosskevin added the bug 🐛 Something doesn't work label Feb 3, 2017
@muibot muibot added PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Feb 3, 2017
@rosskevin
Copy link
Member Author

Checking out error circleci now. Did not have an issue locally.

@rosskevin rosskevin removed the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Feb 3, 2017
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good to me.
It's going to be a breaking change.
Could you add a ##### Breaking Changes section on the CHANGELOG.md so we don't forget it? Thanks.

@muibot muibot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Feb 4, 2017
CHANGELOG.md Outdated
@@ -1,5 +1,11 @@
## HEAD

## 0.16.5
Copy link
Member

@oliviertassinari oliviertassinari Feb 4, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

0.17.0 or just keep it under the HEAD section.

@muibot muibot added PR: Needs Review and removed PR: out-of-date The pull request has merge conflicts and can't be merged labels Feb 4, 2017
@oliviertassinari oliviertassinari changed the title [Core] compatibility - fix version constraints on react and react-tap-event-plugin [core] [core] include react-tap-event-plugin@^2.0.0 for react@^15.4.0 Feb 4, 2017
@oliviertassinari oliviertassinari changed the title [core] [core] include react-tap-event-plugin@^2.0.0 for react@^15.4.0 [core] include react-tap-event-plugin@^2.0.0 for react@^15.4.0 Feb 4, 2017
@oliviertassinari oliviertassinari merged commit 7c10dde into mui:master Feb 4, 2017
@oliviertassinari
Copy link
Member

@rosskevin Thanks

@rosskevin rosskevin deleted the update-react branch February 4, 2017 00:27
@oliviertassinari oliviertassinari changed the title [core] include react-tap-event-plugin@^2.0.0 for react@^15.4.0 [core] Upgrade react-tap-event-plugin and react peer dependency Feb 12, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants