Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tooltip] Add support for horizontalPosition="right" #6072

Merged
merged 1 commit into from
Feb 7, 2017
Merged

[Tooltip] Add support for horizontalPosition="right" #6072

merged 1 commit into from
Feb 7, 2017

Conversation

LeeKevin
Copy link

@LeeKevin LeeKevin commented Feb 7, 2017 •
edited
Loading

Closes #6071

@muibot muibot added PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI and removed PR: Needs Review labels Feb 7, 2017
oliviertassinari
oliviertassinari approved these changes Feb 7, 2017
View reviewed changes
Copy link
Member

@oliviertassinari oliviertassinari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That looks good 👍 .

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work PR: Review Accepted and removed PR: Needs Review PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI labels Feb 7, 2017
@mbrookes mbrookes merged commit 0f6fa79 into mui:master Feb 7, 2017
@muibot muibot added the PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI label Feb 8, 2017
@m2mathew m2mathew mentioned this pull request Feb 28, 2017
Closed
@jpsantos7
Copy link

Hey guys! this is a good idea but it is not quite working.
I'm getting this warning:

Invalid prop verticalPositionof valuecentersupplied toTooltip, expected one of ["top","bottom"].

Additionally the IconButton is not really clickable once the tooltip is on top of it unfortunately.

Maybe a tooltipPosition: 'center-left' would be also cool for when the IconButton is located on the last <td> and the tooltip gets cut on the right because it goes out of the table.

A solution to the button not being clickable when the tooltip is on top of it would be to make the tooltip appear on the right and/or left of the IconButton instead of on the center.
Just my 2 cents.

@oliviertassinari
Copy link
Member

@jpsantos7 I don't see the link with that PR. It's affecting the horizontalPosition property, not the verticalPosition one. Please use the right channel: the issues.

@jpsantos7
Copy link

@oliviertassinari Sorry about that. I changed it to issue #5457

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oliviertassinari oliviertassinari oliviertassinari approved these changes

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work PR: needs revision The pull request can't be merged. More details is available on the code review or fails in the CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@LeeKevin @jpsantos7 @oliviertassinari @mbrookes @muibot