-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test] Add Charts test
#11551
Merged
Merged
[test] Add Charts test
#11551
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
e0e8435
[charts] add unit test pipeline
alexfauquette ef61e88
split script
alexfauquette d95d76d
Update .mocharc.js
alexfauquette 55ac296
feedbacks
alexfauquette dfd79a4
Merge branch 'add-test' of github.com:alexfauquette/mui-x into add-test
alexfauquette File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| // We can't import the `.mocharc.js` of the monorepo, otherwise we trigger its `setupBabel`. | ||
| module.exports = { | ||
| extension: ['js', 'ts', 'tsx'], | ||
| ignore: [ | ||
| '**/build/**', | ||
| '**/node_modules/**', | ||
| // Mocha seems to ignore .next anyway (maybe because dotfiles?). | ||
| // We're leaving this to make sure. | ||
| 'docs/.next/**', | ||
| ], | ||
| recursive: true, | ||
| timeout: (process.env.CIRCLECI === 'true' ? 5 : 2) * 1000, // Circle CI has low-performance CPUs. | ||
| reporter: 'dot', | ||
| require: [ | ||
| require.resolve('../../test/utils/setupBabel'), | ||
| // Not strictly necessary, but just to keep the babel plugins in the loop for the tests | ||
| // For compiling pure ESM modules that @babel/register can't handle. | ||
| // See https://babeljs.io/docs/babel-register#experimental-babel-8-implementation | ||
| // Note: @babel/register does not support compiling native Node.js ES modules on the fly, | ||
| // since currently there is no stable API for intercepting ES modules loading. | ||
| require.resolve('tsx/cjs'), | ||
| require.resolve('../../test/utils/setupJSDOM'), | ||
| ], | ||
| 'watch-ignore': [ | ||
| // default | ||
| '.git', | ||
| // node_modules can be nested with workspaces | ||
| '**/node_modules/**', | ||
| // Unrelated directories with a large number of files | ||
| '**/build/**', | ||
| 'docs/.next/**', | ||
| ], | ||
| spec: ['packages/x-charts/**/*.test.{js,ts,tsx}', 'docs/src/modules/**/*.test.{js,ts,tsx}'], | ||
alexfauquette marked this conversation as resolved.
Show resolved
Hide resolved
|
||
| }; | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { expect } from 'chai'; | ||
| import { FormatterParams } from '../models/seriesType/config'; | ||
| import lineFormatter from './formatter'; | ||
|
|
||
| const seriesOrder = ['id1']; | ||
| const seriesDataset: FormatterParams<'line'>['series'] = { | ||
| id1: { | ||
| // useless info | ||
| type: 'line', | ||
| id: 'id1', | ||
| color: 'red', | ||
| // usefull info | ||
| dataKey: 'k', | ||
| }, | ||
| }; | ||
|
|
||
| const dataSet = [{ k: 1 }, { k: 2 }, { k: 3 }]; | ||
|
|
||
| describe('LineChart - formatter', () => { | ||
| describe('data from dataset', () => { | ||
| it('should get data from the dataset', () => { | ||
| const { series } = lineFormatter({ seriesOrder, series: seriesDataset }, dataSet); | ||
| expect(series.id1.data).to.deep.equal([1, 2, 3]); | ||
| }); | ||
|
|
||
| it('should support missing values', () => { | ||
| const { series } = lineFormatter({ seriesOrder, series: seriesDataset }, [ | ||
| { k: 1 }, | ||
| { k: null }, | ||
| { k: 2 }, | ||
| ]); | ||
| expect(series.id1.data).to.deep.equal([1, null, 2]); | ||
| }); | ||
| }); | ||
| }); |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add a TODO to signal that we want to remove this once ESM issues are solved? It's weird to have different ways to run the tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another option could be to have a
test:uniton every package and then callworkspace run test:unitin the root packagetest:unit, that way having a custom config for charts would be a bit less "hacky". 🙈WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I prefer to keep the hacky feeling, just such that when reading this code it's obvious that something is wrong and need to be fixed (once ESM is done)