Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] v7.8.0 #13655

Merged
merged 9 commits into from
Jun 28, 2024
Merged

[release] v7.8.0 #13655

merged 9 commits into from
Jun 28, 2024

Conversation

KenanYusuf
Copy link
Contributor

No description provided.

@KenanYusuf KenanYusuf added the release We are shipping :D label Jun 28, 2024
@KenanYusuf KenanYusuf requested review from a team and removed request for a team June 28, 2024 11:17
@mui-bot
Copy link

mui-bot commented Jun 28, 2024

Deploy preview: https://deploy-preview-13655--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0d35e00

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
KenanYusuf and others added 2 commits June 28, 2024 12:49
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
@JCQuintas
Copy link
Member

JCQuintas commented Jun 28, 2024

I'm getting an hydration error issue when Watermark component is displayed on master and this branch.

Had to clean my node_modules 🤔

CHANGELOG.md Outdated
- 📈 Support Date data on the BarChart component
- 🖱️ Support modifying the expansion trigger on the Tree View components
- ↕️ Support custom column sort icons on the Data Grid
- 📝 Add "Overlays" section to the Data Grid documentation
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's up for debate, but I think we have too many highlights and not all of them are impact-full enough to be here.

Do we usually add highlights for new doc sections?
Same for the Date data support on BarChart, it makes it look like a major new feature but the PR is super small (#13471)
I could even drop the custom expansion trigger highlight, they are all super small additions compared with the data source.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too sure what constitutes as impactful enough yet, so happy to take the consensus here.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% confident saying which features of other teams is impactful enough.

For eXplore, I'd say nothing this week, on a small release I would keep the "expansion trigger" but it's more to have something to say.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd agree that not adding super-smaller changes to the highlights would put more emphasis on the comparatively larger feature with a much higher anticipated audience. 👍
But I am not sure which ones to keep and which ones to remove.

We could also split the data source highlight into multiple lines and add a bit more detail to improve the emphasis. 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Totally agree that the data source is worth a code snippet 👌 (usually we use a GIF but it's not really a design feature)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same for the Date data support on BarChart, it makes it look like a major new feature but the PR is super small

I don't think the PR size matters. I added it in the changelog because it impacts how charts are rendered if you use Date object. I theory everybody should be happy about this modification, but I prefer to have a highlight to let user see their is a modification

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK if you think the Date support is worth highlighting, you clearly know better than me 👍

CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
@KenanYusuf
Copy link
Contributor Author

KenanYusuf commented Jun 28, 2024

I'm getting an hydration error issue when Watermark component is displayed on master and this branch.

Warning: Prop `style` did not match. Server: "null" Client: "position:absolute;pointer-events:none;color:#8282829e;z-index:100000;width:100%;text-align:center;bottom:50%;right:0;letter-spacing:5px;font-size:24px"
at div
    at Watermark (webpack-internal:///../packages/x-license/src/Watermark/Watermark.tsx:39:5)

@JCQuintas I haven't been able to replicate this - can anyone else? If so, please let me know how.

CHANGELOG.md Show resolved Hide resolved
Co-authored-by: Lukas <llukas.tyla@gmail.com>
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
@KenanYusuf KenanYusuf merged commit e8e8d30 into mui:master Jun 28, 2024
17 checks passed
@KenanYusuf KenanYusuf deleted the release/v7.8.0 branch June 28, 2024 15:44
DungTiger pushed a commit to DungTiger/mui-x that referenced this pull request Jul 23, 2024
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
thomasmoon pushed a commit to thomasmoon/mui-x that referenced this pull request Sep 9, 2024
Signed-off-by: Kenan Yusuf <kenan.m.yusuf@gmail.com>
Co-authored-by: Bilal Shafi <bilalshafidev@gmail.com>
Co-authored-by: Flavien DELANGLE <flaviendelangle@gmail.com>
Co-authored-by: Jose C Quintas Jr <juniorquintas@gmail.com>
Co-authored-by: Alexandre Fauquette <45398769+alexfauquette@users.noreply.github.com>
Co-authored-by: Lukas <llukas.tyla@gmail.com>
@oliviertassinari oliviertassinari changed the title v7.8.0 [release] v7.8.0 Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants