[feature] Implement useTheme processor #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brijeshb42
force-pushed
the
core/use-theme
branch
from
2e9c97b
to
3d5be1b
Compare
brijeshb42
changed the title
to replace the useTheme function calls with an import from Pigment package
brijeshb42
force-pushed
the
core/use-theme
branch
from
3d5be1b
to
2433547
Compare
siriwatknp
reviewed
May 27, 2024
| @@ -0,0 +1,117 @@ | |||
| import { useTheme as _useTheme } from '@pigment-css/react'; | |||
There was a problem hiding this comment.
Where is the runtime useTheme?
There was a problem hiding this comment.
Here's the main PR now - #105
See the description.
siriwatknp
reviewed
May 27, 2024
|
|
||
| export type TemplateCallback = (params: Record<string, unknown> | undefined) => string | number; | ||
|
|
||
| export class UseThemeProcessor extends BaseProcessor { |
There was a problem hiding this comment.
I thought that we were going with option B (babel plugin instead of tagProcessor) from https://www.notion.so/mui-org/material-ui-pigment-non-processor-replacement-0c7e4b150c90499b93cd8fc17c31a009?pvs=4
There was a problem hiding this comment.
I realised that tagProcessor handles all the different kinds of imports that we can have, ie,
import * as lib from 'lib';
import {useTheme} from 'lib';
require('lib')
interopRequire(require('lib'));Doing it ourselves might miss something especially for library code where most of the code is transpiled.
|
Closing in favor or #105 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to replace the useTheme function calls with an import from Pigment package.
Also re-export
RtlProviderfrom@mui/system.Fixes mui/material-ui#42260
There will be a follow-up PR to implement the runtime part from a generated source at build-time.