Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work on decoupling studio server constituents #3482

Merged
merged 2 commits into from
Apr 30, 2024
Merged

Conversation

Janpot
Copy link
Member

@Janpot Janpot commented Apr 30, 2024

Working towards building a handler to serve Toolpad data that can be used in a next.js api route for #3012. Started on a series of refactorings:

  • Remove RuntimeConfig. When running as a react component, we can't rely on config passed through the build. The only thing that was still in there was externalUrl, which was only used for (deprecated) sheets oauth client. Which is editor configuration, not runtime configuration.
  • decouple the project object from the env/data/function managers through the invalidateQueries. Shift the responsibility for query invalidation to the project object.

@Janpot Janpot added the core Infrastructure work going on behind the scenes label Apr 30, 2024
@Janpot Janpot marked this pull request as ready for review April 30, 2024 11:51
@Janpot Janpot requested a review from a team April 30, 2024 11:51
@Janpot Janpot merged commit 78e6b97 into mui:master Apr 30, 2024
12 checks passed
@Janpot Janpot deleted the decouple branch April 30, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants