Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updates all deps and adds types #11

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

achingbrain
Copy link
Member

Updates to the latest version of all deps and adds types.

BREAKING CHANGE: There are now types where before there were none

Updates to the latest version of all deps and adds types.

BREAKING CHANGE: There are now types where before there were none
@alanshaw
Copy link
Member

alanshaw commented Apr 7, 2021

Adding types is breaking? 🧐

@achingbrain
Copy link
Member Author

Only in that people who use a given module may find that the API they’ve coded against isn’t the actual API after all. It’s generally safer to release as a major..

@achingbrain
Copy link
Member Author

Can this be merged & released please? I think you're the only one with npm perms for this module..

@alanshaw
Copy link
Member

alanshaw commented Apr 8, 2021

@hugomrdias is a maintainer also - added you too @achingbrain.

@alanshaw alanshaw merged commit 643bbbb into master Apr 8, 2021
@alanshaw alanshaw deleted the chore/update-deps-and-add-types branch April 8, 2021 11:04
@achingbrain
Copy link
Member Author

Ah, thanks - only your name came up with npm owner ls cid-tool

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants