Add host-header to protocol.csv #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 13, 2022
|
Some discussion around the number and the name here: multiformats/go-multiaddr#185 (comment) |
Host header is required for HTTP based protocol (HTTP, HTTPS, WS, WSS) when DNS(, 4, 6, addr) has been resolved to an IP address and TCP port.
|
changed code from |
|
Unless we get any other feedback, and we want to keep this approach, then I think we can merge this on Monday. Thanks again |
|
Closing this for now, since we ended up just using SNI for this as well. This may come up again in the future though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Host header is required for HTTP based protocol (HTTP, HTTPS, WS, WSS) when DNS(, 4, 6, addr) has been resolved to an IP address and TCP port.
This is required to preserve the host header while resolving a DNS address. The tuple ip:port alone is not sufficient to contact a host via HTTP.
For instance, this is going to be used to address libp2p/go-libp2p#1829
cc @MarcoPolo