Skip to content

Commit

Permalink
lib/math/test_div64: Fix error message formatting
Browse files Browse the repository at this point in the history
Align the expected result with one actually produced for easier visual
comparison; this has to take into account what the format specifiers
will actually produce rather than the characters they consist of.  E.g.:

test_div64: ERROR: 10000000ab275080 / 00000009 => 01c71c71da20d00e,00000002
test_div64: ERROR: expected value              => 0000000013045e47,00000001

(with a failure induced by setting bit #60 of the divident).

Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk>
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
  • Loading branch information
maciej-w-rozycki authored and tsbogend committed Apr 21, 2021
1 parent 6f3377b commit 182dd5b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion lib/math/test_div64.c
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ static inline bool test_div64_verify(u64 quotient, u32 remainder, int i, int j)
if (!test_div64_verify(quotient, remainder, i, j)) { \
pr_err("ERROR: %016llx / %08x => %016llx,%08x\n", \
divident, divisor, quotient, remainder); \
pr_err("ERROR: expected value=> %016llx,%08x\n", \
pr_err("ERROR: expected value => %016llx,%08x\n",\
test_div64_results[i][j].quotient, \
test_div64_results[i][j].remainder); \
result = false; \
Expand Down

0 comments on commit 182dd5b

Please sign in to comment.