Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmesg giving wrong output regarding MPTCP #228

Closed
somnathjena2011 opened this issue Aug 24, 2021 · 4 comments
Closed

dmesg giving wrong output regarding MPTCP #228

somnathjena2011 opened this issue Aug 24, 2021 · 4 comments
Assignees
Labels

Comments

@somnathjena2011
Copy link

I was configuring a new linux kernel 5.6.9 from my Ubuntu 20.04 linux kernel 5.11.0-27-generic.
On doing dmesg | grep MPTCP in 5.11.0-27-generic, following was the output:
[ 1.084739] MPTCP token hash table entries: 4096 (order: 4, 98304 bytes, linear)

On doing dmesg | grep MPTCP in 5.6.9, following the output was NULL

Here are the configurations regarding MPTCP in 5.11.0-27-generic:

CONFIG_MPTCP=y
CONFIG_INET_MPTCP_DIAG=m
CONFIG_MPTCP_IPV6=y

Here are the configurations regarding MPTCP in 5.6.9:

CONFIG_MPTCP=y
CONFIG_MPTCP_IPV6=y
## CONFIG_MPTCP_HMAC_TEST is not set

My question is since MPTCP is included in the configuration and also for IPv6, why is dmesg not showing the version number?

@matttbe
Copy link
Member

matttbe commented Aug 24, 2021

Hello,

First, be careful that there are two major MPTCP implementation in the Linux kernel: https://github.com/multipath-tcp/mptcp_net-next/wiki#upstream-vs-out-of-tree-implementations

Here you are using the upstream implementation and reporting an issue on the 'out-of-tree' project.
I'm going to move this to the other project.

@matttbe matttbe transferred this issue from multipath-tcp/mptcp Aug 24, 2021
@matttbe
Copy link
Member

matttbe commented Aug 24, 2021

My question is since MPTCP is included in the configuration and also for IPv6, why is dmesg not showing the version number?

I'm not sure to understand your question.

MPTCP in the upstream kernel is still under development: https://github.com/multipath-tcp/mptcp_net-next/wiki#changelog
Some features have been added later like the token hash table.
If you don't see it in your v5.6 kernel, it doesn't mean MPTCP is not available. There are other ways to check MPTCP is available: https://developers.redhat.com/blog/2020/08/19/multipath-tcp-on-red-hat-enterprise-linux-8-3-from-0-to-1-subflows/

Can we close the ticket?

@matttbe matttbe self-assigned this Aug 24, 2021
@somnathjena2011
Copy link
Author

somnathjena2011 commented Aug 24, 2021 via email

@matttbe
Copy link
Member

matttbe commented Aug 25, 2021

👍

One last thing before closing this ticket: MPTCP on a v5.6 has very limited features. It was enough to start getting some apps ready but not sure there is an interest to use MPTCP with only one subflow :)
https://github.com/multipath-tcp/mptcp_net-next/wiki#changelog

@matttbe matttbe closed this as completed Aug 25, 2021
jenkins-tessares pushed a commit that referenced this issue Jul 20, 2023
Add a big batch of test coverage to assert all aspects of the tcx link API:

  # ./vmtest.sh -- ./test_progs -t tc_links
  [...]
  #225     tc_links_after:OK
  #226     tc_links_append:OK
  #227     tc_links_basic:OK
  #228     tc_links_before:OK
  #229     tc_links_chain_classic:OK
  #230     tc_links_dev_cleanup:OK
  #231     tc_links_invalid:OK
  #232     tc_links_prepend:OK
  #233     tc_links_replace:OK
  #234     tc_links_revision:OK
  Summary: 10/0 PASSED, 0 SKIPPED, 0 FAILED

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
Link: https://lore.kernel.org/r/20230719140858.13224-9-daniel@iogearbox.net
Signed-off-by: Alexei Starovoitov <ast@kernel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants