Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deathmatch: additional improvements #522

Merged
merged 16 commits into from
Sep 17, 2024

Conversation

jlillis
Copy link
Contributor

@jlillis jlillis commented Jul 18, 2024

This PR makes additional improvements to the new deathmatch resource:

  • Fixes a bug I introduced in deathmatch: tiny cleanup #519. Whoops.
  • Adds a round start timer
  • Disables the area name HUD (dm maps are often made high above the map, area name is not relevant)
  • Fixes next round not starting when mapcycler isn't running
  • Adds spectator mode
  • Adds element data protections

Copy link
Contributor

@Nico8340 Nico8340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So far so good

@jlillis jlillis marked this pull request as draft July 18, 2024 19:28
@jlillis jlillis added this to the Next Release (1.6.1) milestone Aug 7, 2024
@jlillis jlillis changed the title deathmatch: bug fix deathmatch: additional improvements Aug 9, 2024
@Dutchman101
Copy link
Member

Is it about ready for review, @jlillis ?

@jlillis
Copy link
Contributor Author

jlillis commented Aug 14, 2024

I had a few other things to add and one last round of clean up in mind. Hoping to have some free time this weekend to wrap up.

@jlillis jlillis marked this pull request as ready for review September 1, 2024 13:47
@jlillis
Copy link
Contributor Author

jlillis commented Sep 1, 2024

Going to call this ready for review now. Would be nice to see it play-tested with more than myself and a VM to make sure everything works.

@Dutchman101
Copy link
Member

I don't see any problems, but due to how niche "deathmatch" is, there is no better way to actually have it playtested than to put it out there. So merging the PR, to be subject to bug reports/addendums by later suggestion.

@Dutchman101 Dutchman101 merged commit b94ffdd into multitheftauto:master Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants