Update contracts workflow #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CostinCarabas
approved these changes
Mar 21, 2024
andreibancioiu
approved these changes
Mar 21, 2024
| required: false | ||
| type: string | ||
| path-to-sc-meta: | ||
| description: 'multiversx-sc-meta from local' |
There was a problem hiding this comment.
Very good - since it will be used in mx-sdk-rs.
Comment on lines
-77
to
-78
| python3 -m multiversx_sdk_cli.cli config set "dependencies.vmtools.urlTemplate.linux" ${{ inputs.vmtools-repository }} | ||
| python3 -m multiversx_sdk_cli.cli config set "dependencies.vmtools.tag" ${{ inputs.vmtools-version }} |
| then | ||
| sc-meta install mx-scenario-go | ||
| else | ||
| sc-meta install mx-scenario-go --tag ${{ inputs.mx-scenario-go-version }} |
There was a problem hiding this comment.
👍 The thing that triggered this change.
|
|
||
| - name: Generate the contract report | ||
| env: | ||
| RUSTFLAGS: "" | ||
| run: | | ||
| sc-meta all build-dbg --twiggy-paths --target-dir $(pwd)/target --path . | ||
| python3 -m multiversx_sdk_cli.cli contract report --skip-build --skip-twiggy --output-format json --output-file report.json | ||
| mxpy contract report --skip-build --skip-twiggy --output-format json --output-file report.json |
There was a problem hiding this comment.
Since reports aren't yet implemented by sc-meta (as far as we know).
| @@ -213,5 +206,5 @@ jobs: | |||
| env: | |||
| RUSTFLAGS: "" | |||
| with: | |||
| github_token: ${{ secrets.token }} | |||
| github_token: ${{ github.token }} | |||
There was a problem hiding this comment.
Oh, so before was secrets.token. Interesting that the change was necessary.
There was a problem hiding this comment.
I think there is no difference
| @@ -27,15 +27,14 @@ permissions: | |||
| jobs: | |||
| contracts: | |||
| name: Contracts | |||
| uses: multiversx/mx-sc-actions/.github/workflows/contracts.yml@v2 | |||
| uses: multiversx/mx-sc-actions/.github/workflows/contracts.yml@v3 | |||
There was a problem hiding this comment.
Yes, we release it as a new major version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.