Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mordenised, remove polystat dep., fix data links, remove logo dep. #824

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

R-Studio
Copy link

What I changed:

  • Mordenised (Remove deprecated Angular plugins "Graph plugin")
  • Remove dependencies to
    • grafana-polystat-panel -> Replaced by built-in plugin "stat"
    • GitLab logo (for air-gapped Grafana instances)
  • Fixed data links in dashboards
  • Make Prometheus data source selectable (for multi cluster setups)
  • Export the dashboards for externally (remove hardcoded data source, ...)
  • Added dashboard label
  • ...

If you need the entire commit history, take a look: https://github.com/onzack/grafana-dashboards/tree/main/grafana/gitlab-ci-pipelines-exporter

If someone uses the Grafana Operator, they can import it with a GrafanaDashboard custom resource like the following example:

---
apiVersion: grafana.integreatly.org/v1beta1
kind: GrafanaDashboard 
metadata:
  name: gitlab-ci-environments
  labels:
    app: grafana
spec:
  instanceSelector:
    matchLabels:
      grafanaInstance: main
  allowCrossNamespaceImport: true
  datasources:
    - inputName: DS_PROMETHEUS
      datasourceName: ${datasource}
    # Workaround: use "datasources" to overwrite template variable
    - inputName: VAR_GITLAB_HOST
      datasourceName: <YOUR_GITLAB_URL>
  contentCacheDuration: 1h
  folder: "GitLab"
  url: https://raw.githubusercontent.com/onzack/grafana-dashboards/main/grafana/gitlab-ci-pipelines-exporter/environments.json

@mvisonneau
Copy link
Owner

thanks for your contribution @R-Studio, unfortunately I did not seem to be able to get any dashboard to work out of the box with your branch? 🤔
image

@R-Studio
Copy link
Author

thanks for your contribution @R-Studio, unfortunately I did not seem to be able to get any dashboard to work out of the box with your branch? 🤔
image

Yes it works out of the box for me. What are the errors you get? 🤔

@mvisonneau
Copy link
Owner

Here is the main error AFAICT: Failed to upgrade legacy queries Datasource ${DS_PROMETHEUS} was not found

@R-Studio
Copy link
Author

Here is the main error AFAICT: Failed to upgrade legacy queries Datasource ${DS_PROMETHEUS} was not found

How do you import the dashboard, via WebUI?

@mvisonneau
Copy link
Owner

I'm simply trying out the examples/quickstart procedure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants