Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify lifetimes #2

Merged

Conversation

thomaseizinger
Copy link

I think I managed to simplify the lifetimes a bit. It compiles locally and I'd assume you added sufficient tests for all the functionality you want to provide :)

Copy link
Owner

@mxinden mxinden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

Wonderful. Happy these can be removed.

Thank you Thomas!

@mxinden mxinden merged commit 9b01e81 into mxinden:refactor-collector Jul 12, 2023
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants