optimize DefaultParameterHandler create same MeteObject multiple times #2946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazendaz
reviewed
Aug 31, 2023
| import static org.mockito.Mockito.doThrow; | ||
| import static org.mockito.Mockito.mock; | ||
| import static org.mockito.Mockito.when; | ||
| import static org.mockito.Mockito.*; |
There was a problem hiding this comment.
@yffstart Please switch back to actual imports. Avoid star imports.
There was a problem hiding this comment.
Thanks for reply. I have fix it.
…hen obtaining properties of the same parameter object
yffstart
force-pushed
the
mybatis-learn-branch
branch
from
27d50d2
to
3421298
Compare
kazuki43zoo
added
the
polishing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When invoke
DefaultParameterHandler#setParametersto get parameter's property values using MetaObject,parameterMappingswill create the sameMetaObjectmultiple times during traversal. I think this can be avoided in order to reduce object creation.