Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update token actions popover #562

Merged
merged 1 commit into from
Apr 10, 2022
Merged

Conversation

dweberdev
Copy link
Contributor

Screen Shot 2022-04-05 at 3 38 37 PM

Screen Shot 2022-04-05 at 3 38 46 PM

@netlify
Copy link

netlify bot commented Apr 5, 2022

Deploy Preview for eager-poitras-f19dbe ready!

Name Link
🔨 Latest commit 9350f10
🔍 Latest deploy log https://app.netlify.com/sites/eager-poitras-f19dbe/deploys/624cc51e0754f80009a7f873
😎 Deploy Preview https://deploy-preview-562--eager-poitras-f19dbe.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@dweberdev
Copy link
Contributor Author

Headless ui popover has a solution that uses react-popper and refs but it has a weird bug that is positioning the popover on the top left corner of the screen.

I also implemented andt popover as well but it was a pain to style and match our needs.

This solution seems to work great. I'm open to a discussion whether this is a solid approach.

@dweberdev dweberdev requested a review from dospore April 5, 2022 22:43
@dospore
Copy link
Contributor

dospore commented Apr 5, 2022

Headless ui popover has a solution that uses react-popper and refs but it has a weird bug that is positioning the popover on the top left corner of the screen.

what was the original issue and solution? I remember it was pushing the div down, was the solution just to make the popover absolute?

@dweberdev
Copy link
Contributor Author

It would've worked if it wasn't for being inside a table.

The position of the dropdown is absolute but anything I used as position relative inside the table caused to expand the table because of the overflow value we have to use for responsive tables.

If I use something outside of the table as position relative, it will take a lot of messy css to adjust and prone to bugs.

Headless UI recommends an alternative to using position absolute but using refs and react-popper but I kept having issues as some other people: tailwindlabs/headlessui#985

@dospore
Copy link
Contributor

dospore commented Apr 8, 2022

It would've worked if it wasn't for being inside a table.

The position of the dropdown is absolute but anything I used as position relative inside the table caused to expand the table because of the overflow value we have to use for responsive tables.

If I use something outside of the table as position relative, it will take a lot of messy css to adjust and prone to bugs.

Headless UI recommends an alternative to using position absolute but using refs and react-popper but I kept having issues as some other people: tailwindlabs/headlessui#985

mmmmm sounds like a weird one, happy to use this for this case. Do you think its worth going through and updating the rest of the popovers??

@dweberdev
Copy link
Contributor Author

mmmmm sounds like a weird one, happy to use this for this case. Do you think its worth going through and updating the rest of the popovers??

I like keeping the app consistent. Headless ui popover will work as long as its not inside a container with overflow: scroll

@dospore
Copy link
Contributor

dospore commented Apr 10, 2022

mmmmm sounds like a weird one, happy to use this for this case. Do you think its worth going through and updating the rest of the popovers??

I like keeping the app consistent. Headless ui popover will work as long as its not inside a container with overflow: scroll

Could be one to go through and remove headless ui popover in place of tiny-popover

@dospore dospore merged commit 829bd4f into release-v2 Apr 10, 2022
@dospore dospore deleted the v2/token-actions-popover branch April 10, 2022 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants