Expose all pip dependencies in requirements.txt #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rather than extending another dockerfile with its own pip dependencies (that we can't change b/c its in a git submodule for a project we don't have sway over), fold it all into one Dockerfile.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bulk of the pip dependencies for this project are locked away in a Dockerfile that our project extends. This change breaks the dependency on that 'base' dockerfile by folding all that it does into ours, and then taking all the pip dependencies out of the dockerfile and into our requirements.txt file.
This will make managing those dependencies possible going forward (and seeing them all)...there are probably a ton of these we don't need (but I don't think we necessarily need to focus on shaving them off at the moment).