Fix: use correct way to inject search value #750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using an order prefix in Magento (like `ORD00000123456` instead of just `00000123456`), the `$searchValue` is cast to an `int`. This presumably done to avoid SQL injections, so I changed it to using the second parameter of `where()` so Magento escapes it for us and SQL injections are avoided. This way, we can use strings to look for orders with an increment ID instead of a numeric value.
|
Funny, my colleague @ArjenMiedema fixed the exact same bug in 2021; #606 But you closed the PR saying that you solved it differently somewhere else. Apparently it didn't? The file hasn't been touched during that time period until the PHP 8.1 came; https://github.com/myparcelnl/magento/commits/main/Plugin/Magento/Sales/Api/Data/OrderExtension.php |
joerivanveen
previously approved these changes
Jan 30, 2023
joerivanveen
approved these changes
Jan 30, 2023
Mark-Ernst
approved these changes
Jan 31, 2023
EdieLemoine
pushed a commit
that referenced
this pull request
Feb 2, 2023
MyParcelBot
pushed a commit
that referenced
this pull request
Feb 2, 2023
## [4.8.1](v4.8.0...v4.8.1) (2023-02-02) ### 🐛 Bug Fixes * clarify texts regarding mailbox settings ([#745](#745)) ([8d33bd9](8d33bd9)) * fix division by zero issue on checkout ([#746](#746)) ([cee3094](cee3094)) * fix php 8.1 deprecation notice in strtotime ([#748](#748)) ([eca47d6](eca47d6)) * mailbox works with kilo setting on php 8.1 ([#744](#744)) ([721259a](721259a)) * prevent type error in use entity id ([#749](#749)) ([57a05a7](57a05a7)) * use correct way to inject search value ([#750](#750)) ([d11f3e0](d11f3e0))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an order prefix in Magento (like
ORD00000123456instead of just00000123456), the$searchValueis cast to anint.This presumably done to avoid SQL injections, so I changed it to using the second parameter of
where()so Magento escapes it for us and SQL injections are avoided. This way, we can use strings to look for orders with an increment ID instead of only a numeric value.The resulting query previously resulted in fetching all orders since the
$searchValuebecame0. Because we have 500k+ orders, this resulted in an out of memory error.