Expose server's middleware for incoming clients control #55
Conversation
Waldz
requested review from
iberflow,
anjmao,
tadaskay,
soffokl,
zolia and
vkuznecovas
Waldz
force-pushed
the
feature/expose-server-auth-control
branch
from
7e55222
to
b07bacd
Compare
| password := event.Env["password"] | ||
| err := m.authenticateClient(event.ClientID, event.ClientKey, username, password) | ||
| if err != nil { | ||
| log.Error("Unable to authenticate client:", err) |
There was a problem hiding this comment.
Are we just logging the auth problem and not returning an error?
There was a problem hiding this comment.
Did not change this logic. Probably, middleware just logs returning returned errors also.
If you mean returning error to connecting client, it's intentional. Client gets just "wrong username or password"
| type middleware struct { | ||
| *auth.Middleware |
There was a problem hiding this comment.
Simple inheritances. auth.Middleware general purpose - subscribes to client status events
There was a problem hiding this comment.
There is no inheritance for golang, that is why it looks weird when you are trying to invent it yourself.
|
|
||
| return true, nil | ||
| } | ||
| func (m *middleware) ConsumeLine(line string) (bool, error) { return false, nil } |
There was a problem hiding this comment.
It doesn't consume lines anymore?
There was a problem hiding this comment.
Yes, now subscribes for consumer client from auth.Middleware
Waldz
force-pushed
the
feature/expose-server-auth-control
branch
from
2471728
to
42b4559
Compare
Waldz
force-pushed
the
feature/expose-server-auth-control
branch
from
42b4559
to
ae74469
Compare
Updates: mysteriumnetwork/node#1838