* fix some violation of ReSharper inspections

- method `AcquireUidLocksForSave()` that being unused since 10d5cbd @ UserSaver.cs @ c#/crawler
n0099 · Jul 11, 2024 · de7d94c · de7d94c
1 parent 5a599c9
commit de7d94c
Show file tree

Hide file tree

Showing 10 changed files with 9 additions and 11 deletions.
diff --git a/c#/crawler/src/Db/LatestReplier.cs b/c#/crawler/src/Db/LatestReplier.cs
@@ -1,4 +1,5 @@
-namespace tbm.Crawler.Db;
+// ReSharper disable PropertyCanBeMadeInitOnly.Global
+namespace tbm.Crawler.Db;
 
 public class LatestReplier : BaseUser
 {

diff --git a/c#/crawler/src/Tieba/Crawl/Saver/Post/SubReplySaver.cs b/c#/crawler/src/Tieba/Crawl/Saver/Post/SubReplySaver.cs
@@ -30,7 +30,7 @@ protected override Lazy<Dictionary<Type, AddSplitRevisionsDelegate>>
         _addSplitRevisionsDelegatesKeyByEntityType ??= new(() => new()
         {
             {typeof(SubReplyRevision.SplitAgreeCount), AddRevisionsWithDuplicateIndex<SubReplyRevision.SplitAgreeCount>},
-            {typeof(SubReplyRevision.SplitDisagreeCount), AddRevisionsWithDuplicateIndex<SubReplyRevision.SplitDisagreeCount>},
+            {typeof(SubReplyRevision.SplitDisagreeCount), AddRevisionsWithDuplicateIndex<SubReplyRevision.SplitDisagreeCount>}
         });
 
     protected override Spid RevisionIdSelector(BaseSubReplyRevision entity) => entity.Spid;

diff --git a/c#/crawler/src/Tieba/Crawl/Saver/SaverWithRevision.cs b/c#/crawler/src/Tieba/Crawl/Saver/SaverWithRevision.cs
@@ -1,5 +1,3 @@
-using Microsoft.EntityFrameworkCore.ChangeTracking;
-
 namespace tbm.Crawler.Tieba.Crawl.Saver;
 
 public abstract partial class SaverWithRevision<TBaseRevision, TRevisionId>(

diff --git a/c#/crawler/src/Tieba/Crawl/Saver/UserSaver.cs b/c#/crawler/src/Tieba/Crawl/Saver/UserSaver.cs
@@ -1,5 +1,3 @@
-using Microsoft.EntityFrameworkCore.ChangeTracking;
-
 namespace tbm.Crawler.Tieba.Crawl.Saver;
 
 public partial class UserSaver(
@@ -43,9 +41,6 @@ where newlyLocked.Contains(user.Uid)
             userFieldRevisionIgnorance);
     }
 
-    public IEnumerable<Uid> AcquireUidLocksForSave(IEnumerable<Uid> usersId) =>
-        _saverLocks.Value.Acquire(usersId.ToList());
-
     public void OnPostSave() => _saverLocks.Value.Dispose();
 }
 public partial class UserSaver

diff --git a/c#/crawler/src/Worker/ProcessImagesInAllReplyContentsWorker.cs b/c#/crawler/src/Worker/ProcessImagesInAllReplyContentsWorker.cs
@@ -1,5 +1,6 @@
 namespace tbm.Crawler.Worker;
 
+// ReSharper disable once UnusedType.Global
 public class ProcessImagesInAllReplyContentsWorker(
     ILogger<ProcessImagesInAllReplyContentsWorker> logger,
     IConfiguration config,

diff --git a/c#/crawler/src/Worker/RetryCrawlWorker.cs b/c#/crawler/src/Worker/RetryCrawlWorker.cs
@@ -37,6 +37,7 @@ protected override async Task DoWork(CancellationToken stoppingToken)
         var pages = failureCountsKeyByPage.Keys.ToList();
         FailureCount FailureCountSelector(Page p) => failureCountsKeyByPage[p];
 
+        // ReSharper disable once SwitchStatementMissingSomeEnumCasesNoDefault
         switch (lockType)
         {
             case CrawlerLocks.Type.Thread:

diff --git a/c#/imagePipeline/src/Db/ImageWithFrameIndex.cs b/c#/imagePipeline/src/Db/ImageWithFrameIndex.cs
@@ -1,3 +1,4 @@
+// ReSharper disable PropertyCanBeMadeInitOnly.Global
 namespace tbm.ImagePipeline.Db;
 
 public abstract class ImageWithFrameIndex : EntityWithImageId

diff --git a/c#/shared/src/Db/EntityWithImageId.cs b/c#/shared/src/Db/EntityWithImageId.cs
@@ -1,3 +1,4 @@
+// ReSharper disable PropertyCanBeMadeInitOnly.Global
 using System.ComponentModel.DataAnnotations;
 
 namespace tbm.Shared.Db;

diff --git a/c#/shared/src/Db/RowVersionedEntity.cs b/c#/shared/src/Db/RowVersionedEntity.cs
@@ -1,3 +1,4 @@
+// ReSharper disable PropertyCanBeMadeInitOnly.Global
 using System.ComponentModel.DataAnnotations;
 
 namespace tbm.Shared.Db;

diff --git a/c#/shared/src/TransformEntityWorker.cs b/c#/shared/src/TransformEntityWorker.cs
@@ -3,7 +3,6 @@
 using System.Text.Json;
 using System.Text.Unicode;
 using Microsoft.EntityFrameworkCore.ChangeTracking;
-using SuperLinq;
 using tbm.Shared.Db;
 
 namespace tbm.Shared;
@@ -14,7 +13,7 @@ public abstract class TransformEntityWorker()
     protected static readonly JsonSerializerOptions JsonSerializerOptions = new()
     {
         IncludeFields = true,
-        Encoder = JavaScriptEncoder.Create(UnicodeRanges.All),
+        Encoder = JavaScriptEncoder.Create(UnicodeRanges.All)
     };
 }