Fix varying line number widths #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a bug that occurs when the cursor moves and the character width of the line number changes. Sets the character width equal to the character width of the number of lines in the document. Forces a monospace font for the gutter.
|
@nadavspi is this still an active project? Let me know if there's anything I can change in the PR. |
|
Would love to have this reviewed and merged soon :) |
ditsuke
reviewed
May 31, 2023
| } | ||
|
|
||
| toDOM() { | ||
| return document.createTextNode(this.text); | ||
| } | ||
| } | ||
|
|
||
| function linesCharLength(state: EditorState): number { | ||
| /** |
ditsuke
approved these changes
May 31, 2023
|
Please merge this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug (#10) that occurs when the cursor moves and the character width of the line number changes. Sets the character width equal to the character width of the number of lines in the document. Forces a monospace font for the gutter.