Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix processing of fields for classes deriving from MarshalByRefObject #158

Merged

Conversation

josesimoes
Copy link
Member

@josesimoes josesimoes commented Oct 11, 2022

Description

  • The nested field counter now ignores MarshalByRefObject base type.

Motivation and Context

  • Mono Cecil was resolving MarshalByRefObject to full .NET mscorlib, thus grabbing wrong information about the class, in particular the class fields. This was causing the offset count for nested fields to be bumped when it shouldn't be.

How Has This Been Tested?

Screenshots

Types of changes

  • Improvement (non-breaking change that improves a feature, code or algorithm)
  • Bug fix (non-breaking change which fixes an issue with code or algorithm)
  • New feature (non-breaking change which adds functionality to code)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Config and build (change in the configuration and build system, has no impact on code or features)
  • Dependencies (update dependencies and changes associated, has no impact on code or features)
  • Unit Tests (add new Unit Test(s) or improved existing one(s), has no impact on code or features)
  • Documentation (changes or updates in the documentation, has no impact on code or features)

Checklist:

  • My code follows the code style of this project (only if there are changes in source code).
  • My changes require an update to the documentation (there are changes that require the docs website to be updated).
  • I have updated the documentation accordingly (the changes require an update on the docs in this repo).
  • I have read the CONTRIBUTING document.
  • I have tested everything locally and all new and existing tests passed (only if there are changes in source code).
  • I have added new tests to cover my changes.

- Now the nested field counter is ignoring this base type.
@josesimoes josesimoes force-pushed the fix-processing-MarshalByRefObject branch from da7dad3 to 23d3345 Compare October 11, 2022 14:36
@josesimoes josesimoes merged commit 5760ada into nanoframework:develop Oct 11, 2022
@josesimoes josesimoes deleted the fix-processing-MarshalByRefObject branch October 11, 2022 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants