Skip to content

Commit

Permalink
Add udf compiler unit tests (NVIDIA#583)
Browse files Browse the repository at this point in the history
* Add udf compiler unit tests

- This change includes unit tests for implemented udf opcodes

Signed-off-by: Allen Xu <allxu@nvidia.com>

Co-authored-by: Sean Lee <selee@nvidia.com>
Co-authored-by: Nicholas Edelman <nedelman@nvidia.com>
Co-authored-by: Alessandro Bellina <abellina@nvidia.com>

* Remove extra space lines in tests

Signed-off-by: Allen Xu <allxu@nvidia.com>

* Remove irrelevant comment

Signed-off-by: Sean Lee <selee@nvidia.com>

* Get the store index correctly

Signed-off-by: Sean Lee <selee@nvidia.com>

* Fix the ldc test

Signed-off-by: Sean Lee <selee@nvidia.com>

* Mark un-compiled test cases

Signed-off-by: Allen Xu <allxu@nvidia.com>

* Rename fall-back test cases

Signed-off-by: Allen Xu <allxu@nvidia.com>

* Fix column comparison

x.except(y) doesn't actually perform element-wise comparison
between x and y.  It returns a new dataframe with the rows from
x that do not appear in y.
It was producing false-positives with some unit tests.

Signed-off-by: Sean Lee <selee@nvidia.com>

* Improve the column comparison performance further

Signed-off-by: Sean Lee <selee@nvidia.com>

Co-authored-by: Allen Xu <allxu@nvidia.com>
Co-authored-by: Sean Lee <selee@nvidia.com>
Co-authored-by: Nicholas Edelman <nedelman@nvidia.com>
Co-authored-by: Alessandro Bellina <abellina@nvidia.com>
  • Loading branch information
5 people authored Aug 29, 2020
1 parent c296db6 commit 6552ff6
Show file tree
Hide file tree
Showing 2 changed files with 1,789 additions and 23 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -528,7 +528,9 @@ object Instruction {
val opcode: Int = codeIterator.byteAt(offset)
val operand: Int = opcode match {
case Opcode.ALOAD | Opcode.DLOAD | Opcode.FLOAD |
Opcode.ILOAD | Opcode.LLOAD | Opcode.LDC =>
Opcode.ILOAD | Opcode.LLOAD | Opcode.LDC |
Opcode.ASTORE | Opcode.DSTORE | Opcode.FSTORE |
Opcode.ISTORE | Opcode.LSTORE =>
codeIterator.byteAt(offset + 1)
case Opcode.BIPUSH =>
codeIterator.signedByteAt(offset + 1)
Expand Down
Loading

0 comments on commit 6552ff6

Please sign in to comment.