Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed duplicate kv/object store lists when unexpected stream types were included #486

Merged
merged 2 commits into from
Mar 3, 2023

Conversation

aricart
Copy link
Member

@aricart aricart commented Mar 1, 2023

[FIX] Lister was filtering stream responses for objectstore and kv, but offset calculations are made as a whole. Added check of total count that lister results are not duplicated.

@aricart aricart requested a review from piotrpio March 1, 2023 18:32
Copy link
Contributor

@piotrpio piotrpio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…ut offset calculations are made as a whole. Added check of total count that lister results are not duplicated.
@aricart aricart changed the base branch from main to dev March 3, 2023 00:32
@aricart aricart changed the base branch from dev to main March 3, 2023 00:32
@aricart aricart merged commit 1660798 into main Mar 3, 2023
@aricart aricart deleted the lister-fix branch May 12, 2023 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants