Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update NATS.Client.Hosting package as NATS.Extensions.Microsoft.DependencyInjection #433

Merged
merged 8 commits into from
Apr 3, 2024
Merged

Update NATS.Client.Hosting package as NATS.Extensions.Microsoft.DependencyInjection #433

merged 8 commits into from
Apr 3, 2024

Conversation

rickdotnet
Copy link
Collaborator

@rickdotnet rickdotnet commented Mar 6, 2024 •
edited
Loading

Aims to resolve #392 and resolve #417

The builder pattern is fairly common and easy to pick up. This also leaves it fairly open to future extension.

var services = new ServiceCollection();

services.AddNats(builder => builder.AddJsonSerialization(MyJsonContext.Default));
services.AddNats(builder => builder.WithPoolSize(2).WithKey(key2));

@rickdotnet rickdotnet marked this pull request as ready for review March 13, 2024 11:12
@mtmk mtmk added this to the 2.1.5 milestone Mar 27, 2024
@mtmk mtmk self-assigned this Mar 27, 2024
@mtmk mtmk added the enhancement New feature or request label Mar 27, 2024
mtmk added a commit that referenced this pull request Mar 28, 2024
@mtmk
Release 2.1.5
acdb605 
* #451
* #433
* #454
@mtmk mtmk mentioned this pull request Mar 28, 2024
Merged
@mtmk
Merge remote-tracking branch 'origin/main' into feature/392-417-di-bu…
fcc8d99 
…ilder

# Conflicts:
#	tests/NATS.Extensions.Microsoft.DependencyInjection.Tests/NatsHostingExtensionsTests.cs
mtmk
mtmk approved these changes Apr 3, 2024
View reviewed changes
Copy link
Collaborator

@mtmk mtmk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtmk mtmk merged commit 8705f64 into nats-io:main Apr 3, 2024
10 checks passed
@mtmk
Copy link
Collaborator

mtmk commented Apr 3, 2024

thanks @rickdotnet

@rickdotnet rickdotnet deleted the feature/392-417-di-builder branch April 3, 2024 22:23
mtmk added a commit that referenced this pull request Apr 4, 2024
@mtmk
Release 2.2.0 (#456)
44a2191 
* #451 Dispose fixes
* #433 Update NATS.Client.Hosting package as NATS.Extensions.Microsoft.DependencyInjection
* (staged) #454 Add client certificate chain support and SSL context generation
   * #463 add NatsTlsOpts.LoadClientCertContext 
* #459 Object store metadata fix
* #455 Deserialize empty payloads
* Release 2.2.0

[nats:update-docs]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtmk mtmk mtmk approved these changes

Assignees

@mtmk mtmk

Labels
enhancement New feature or request
Projects
None yet
Milestone
2.2.0
2 participants
@rickdotnet @mtmk