Honor sub count limits for raw/dump #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Chris" on nats slack reported that `nats sub $subject --count $N` did not work with `--raw`; analysis of code exposed that this also does not work with `--raw`. Adjust the control flow in the registered handler function to treat the pretty-case as another branch, before final clean-up; I rejected the "duplicate the limit check in two other places" approach as not scaling if more work needs to be done on each branch.
ripienaar
approved these changes
Jun 10, 2022
|
Thank you :) |
|
How did I write |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Chris" on nats slack reported that
nats sub $subject --count $Ndid not work with--raw; analysis of code exposed that this also does not work with--raw.Adjust the control flow in the registered handler function to treat the pretty-case as another branch, before final clean-up; I rejected the "duplicate the limit check in two other places" approach as not scaling if more work needs to be done on each branch.