Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Acknowledgment spelling consistent #657

Merged
merged 2 commits into from
Dec 21, 2022
Merged

Make Acknowledgment spelling consistent #657

merged 2 commits into from
Dec 21, 2022

Conversation

Jarema
Copy link
Member

@Jarema Jarema commented Dec 20, 2022

Found a typo in the Consumer state. Acknowledgment -> Acknowledgement.

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
@@ -658,9 +658,9 @@ func (c *consumerCmd) showInfo(config api.ConsumerConfig, state api.ConsumerInfo

if config.AckPolicy != api.AckNone {
if state.AckFloor.Last == nil {
fmt.Printf(" Acknowledgment floor: Consumer sequence: %s Stream sequence: %s\n", humanize.Comma(int64(state.AckFloor.Consumer)), humanize.Comma(int64(state.AckFloor.Stream)))
fmt.Printf(" Acknowledgement floor: Consumer sequence: %s Stream sequence: %s\n", humanize.Comma(int64(state.AckFloor.Consumer)), humanize.Comma(int64(state.AckFloor.Stream)))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In american it's Acknowledgment and in british its Acknowledgement. Both are corect but we tend to use american english here

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, but checking the codebase, everywhere else British version is used.
Should not call it "typo" though ;).
Those are only two uses of american ones for that word.

Examples:

	if c.maxAckPending == -1 && cfg.AckPolicy != api.AckNone {
		err = askOne(&survey.Input{
			Message: "Maximum Acknowledgements Pending",
			Default: "0",
			Help:    "The maximum number of messages without acknowledgement that can be outstanding, once this limit is reached message delivery will be suspended. Settable using --max-pending.",
		}, &c.maxAckPending)
		fisk.FatalIfError(err, "could not ask for maximum outstanding acknowledgements")
	}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think we should make those American then :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree, will "reverse" this PR approach :)

Signed-off-by: Tomasz Pietrek <tomasz@nats.io>
Copy link
Collaborator

@ripienaar ripienaar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Jarema Jarema changed the title Fix typo in Consumer State Make Acknowledgment spelling consistent. Dec 21, 2022
@Jarema Jarema changed the title Make Acknowledgment spelling consistent. Make Acknowledgment spelling consistent Dec 21, 2022
@Jarema Jarema merged commit ec5d99c into main Dec 21, 2022
@ripienaar ripienaar deleted the jarema/fix-typo branch January 29, 2023 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants