Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rollback context if edit invalid #682

Merged
merged 4 commits into from
Jan 26, 2023
Merged

Rollback context if edit invalid #682

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
9e5ef18
rollback if nsc url is invalid
sethjback Jan 25, 2023
1a72a8a
Merge branch 'main' into nsc-edit-context
sethjback Jan 26, 2023
ee1f972
updated error return
sethjback Jan 26, 2023
7597989
update error return
sethjback Jan 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion cli/context_command.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,7 +174,15 @@ func (c *ctxCommand) editCommand(pc *fisk.ParseContext) error {
return err
}

return c.showCommand(pc)
// There was an error with some data in the modified config
// Save the known clean version and show the error
err = c.showCommand(pc)
if err != nil {
ctx.Save(c.name)
return fmt.Errorf("updated context validation failed - rolling back changes: %w", err)
}

return nil
}

func (c *ctxCommand) renderListCompletion(current string, known []*natscontext.Context) {
Expand Down