Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

Commit

Permalink
split 200 and 422 date filter test into two tests
Browse files Browse the repository at this point in the history
  • Loading branch information
Rwolfe-Nava committed Aug 5, 2024
1 parent dc9f2f4 commit c23a781
Showing 1 changed file with 52 additions and 52 deletions.
104 changes: 52 additions & 52 deletions api/tests/src/api/opportunities_v1/test_opportunity_route_search.py
Original file line number Diff line number Diff line change
Expand Up @@ -711,67 +711,67 @@ def test_search_filters_200(
call_search_and_validate(client, api_auth_token, search_request, expected_results)

@pytest.mark.parametrize(
"search_request, expected_status_code",
"search_request",
[
# Post Date
(get_search_request(post_date={"start_date": None}), 200),
(get_search_request(post_date={"end_date": None}), 200),
(get_search_request(post_date={"start_date": "2020-01-01"}), 200),
(get_search_request(post_date={"end_date": "2020-02-01"}), 200),
(get_search_request(post_date={"start_date": None, "end_date": None}), 200),
(get_search_request(post_date={"start_date": "2020-01-01", "end_date": None}), 200),
(get_search_request(post_date={"start_date": None, "end_date": "2020-02-01"}), 200),
(
get_search_request(
post_date={"start_date": "2020-01-01", "end_date": "2020-02-01"}
),
200,
),
(get_search_request(post_date={"start_date": "I am not a date"}), 422),
(get_search_request(post_date={"start_date": "123-456-789"}), 422),
(get_search_request(post_date={"start_date": "5"}), 422),
(get_search_request(post_date={"start_date": 5}), 422),
(get_search_request(post_date={"end_date": "I am not a date"}), 422),
(get_search_request(post_date={"end_date": "123-456-789"}), 422),
(get_search_request(post_date={"end_date": "5"}), 422),
(get_search_request(post_date={"end_date": 5}), 422),
(get_search_request(post_date={"start_date": None})),
(get_search_request(post_date={"end_date": None})),
(get_search_request(post_date={"start_date": "2020-01-01"})),
(get_search_request(post_date={"end_date": "2020-02-01"})),
(get_search_request(post_date={"start_date": None, "end_date": None})),
(get_search_request(post_date={"start_date": "2020-01-01", "end_date": None})),
(get_search_request(post_date={"start_date": None, "end_date": "2020-02-01"})),
(get_search_request(post_date={"start_date": "2020-01-01", "end_date": "2020-02-01"})),
# Close Date
(get_search_request(close_date={"start_date": None}), 200),
(get_search_request(close_date={"end_date": None}), 200),
(get_search_request(close_date={"start_date": "2020-01-01"}), 200),
(get_search_request(close_date={"end_date": "2020-02-01"}), 200),
(get_search_request(close_date={"start_date": None, "end_date": None}), 200),
(get_search_request(close_date={"start_date": "2020-01-01", "end_date": None}), 200),
(get_search_request(close_date={"start_date": None, "end_date": "2020-02-01"}), 200),
(
get_search_request(
close_date={"start_date": "2020-01-01", "end_date": "2020-02-01"}
),
200,
),
(get_search_request(close_date={"start_date": "I am not a date"}), 422),
(get_search_request(close_date={"start_date": "123-456-789"}), 422),
(get_search_request(close_date={"start_date": "5"}), 422),
(get_search_request(close_date={"start_date": 5}), 422),
(get_search_request(close_date={"end_date": "I am not a date"}), 422),
(get_search_request(close_date={"end_date": "123-456-789"}), 422),
(get_search_request(close_date={"end_date": "5"}), 422),
(get_search_request(close_date={"end_date": 5}), 422),
(get_search_request(close_date={"start_date": None})),
(get_search_request(close_date={"end_date": None})),
(get_search_request(close_date={"start_date": "2020-01-01"})),
(get_search_request(close_date={"end_date": "2020-02-01"})),
(get_search_request(close_date={"start_date": None, "end_date": None})),
(get_search_request(close_date={"start_date": "2020-01-01", "end_date": None})),
(get_search_request(close_date={"start_date": None, "end_date": "2020-02-01"})),
(get_search_request(close_date={"start_date": "2020-01-01", "end_date": "2020-02-01"})),
],
)
def test_search_validate_date_filters(
self, client, api_auth_token, search_request, expected_status_code
):
def test_search_validate_date_filters_200(self, client, api_auth_token, search_request):
resp = client.post(
"/v1/opportunities/search", json=search_request, headers={"X-Auth": api_auth_token}
)
assert resp.status_code == 200

@pytest.mark.parametrize(
"search_request",
[
# Post Date
(get_search_request(post_date={"start_date": "I am not a date"})),
(get_search_request(post_date={"start_date": "123-456-789"})),
(get_search_request(post_date={"start_date": "5"})),
(get_search_request(post_date={"start_date": 5})),
(get_search_request(post_date={"end_date": "I am not a date"})),
(get_search_request(post_date={"end_date": "123-456-789"})),
(get_search_request(post_date={"end_date": "5"})),
(get_search_request(post_date={"end_date": 5})),
# Close Date
(get_search_request(close_date={"start_date": "I am not a date"})),
(get_search_request(close_date={"start_date": "123-456-789"})),
(get_search_request(close_date={"start_date": "5"})),
(get_search_request(close_date={"start_date": 5})),
(get_search_request(close_date={"end_date": "I am not a date"})),
(get_search_request(close_date={"end_date": "123-456-789"})),
(get_search_request(close_date={"end_date": "5"})),
(get_search_request(close_date={"end_date": 5})),
],
)
def test_search_validate_date_filters_422(self, client, api_auth_token, search_request):
resp = client.post(
"/v1/opportunities/search", json=search_request, headers={"X-Auth": api_auth_token}
)
assert resp.status_code == expected_status_code
assert resp.status_code == 422

if resp.status_code == 422:
json = resp.get_json()
error = json["errors"][0]
assert json["message"] == "Validation error"
assert error["message"] == "Not a valid date."
json = resp.get_json()
error = json["errors"][0]
assert json["message"] == "Validation error"
assert error["message"] == "Not a valid date."

@pytest.mark.parametrize(
"search_request, expected_results",
Expand Down

0 comments on commit c23a781

Please sign in to comment.