Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[Task]: Remove Dynaconf from Analytics #115

Closed
3 tasks
aplybeah opened this issue Jun 28, 2024 · 1 comment · Fixed by #136
Closed
3 tasks

[Task]: Remove Dynaconf from Analytics #115

aplybeah opened this issue Jun 28, 2024 · 1 comment · Fixed by #136

Comments

@aplybeah
Copy link

Summary

After getting feedback for #107, the consensus was to reevaluate the way the database loader works for more uniformity. Changes will need to be made primarily in db.py and cli.py

Acceptance criteria

  • Dynaconf and related files removed
  • Database connections work as expected
  • Integrations such as Slack and Github work as expected
@aplybeah aplybeah self-assigned this Jun 28, 2024
@aplybeah aplybeah mentioned this issue Jun 28, 2024
Closed
1 task
@aplybeah aplybeah mentioned this issue Jul 8, 2024
Merged
@acouch
Copy link
Member

acouch commented Sep 17, 2024

Issue migrated to HHS#2057

This was referenced Sep 17, 2024
Closed
Closed
@acouch acouch removed the Migrated label Sep 17, 2024
acouch pushed a commit that referenced this issue Sep 18, 2024
@aplybeah @acouch
[Task] Update analytics db to use local.env and Remove Dynaconf from …
f21be00 
…Analytics (#136)

Fixes #107
Fixes #115

* removed the `*.toml` files related to dynaconf
* removed references to Dynaconf (e.g. in Docstrings, gitignore)
* use Pydantic for loading

> After getting feedback for
#107, the consensus
was to reevaluate the way the database loader works for more uniformity.
Changes will need to be made primarily in db.py and cli.py
>
> With the PR #84 ,
the env settings for the db are stored in settings.toml. The config
settings should be updated to use the existing local.env file

> Screenshots, GIF demos, code examples or output to help show the
changes working as expected.
acouch pushed a commit that referenced this issue Sep 18, 2024
@aplybeah @acouch
[Task] Update analytics db to use local.env and Remove Dynaconf from …
df5d7d6 
…Analytics (#136)

Fixes #107
Fixes #115

* removed the `*.toml` files related to dynaconf
* removed references to Dynaconf (e.g. in Docstrings, gitignore)
* use Pydantic for loading

> After getting feedback for
#107, the consensus
was to reevaluate the way the database loader works for more uniformity.
Changes will need to be made primarily in db.py and cli.py
>
> With the PR #84 ,
the env settings for the db are stored in settings.toml. The config
settings should be updated to use the existing local.env file

> Screenshots, GIF demos, code examples or output to help show the
changes working as expected.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@acouch @aplybeah