Skip to content
This repository has been archived by the owner on Sep 18, 2024. It is now read-only.

[Task]: Finish adding Postgres Integration to Analytics Library #45

Closed
3 tasks
acouch opened this issue May 20, 2024 · 4 comments · Fixed by #72
Closed
3 tasks

[Task]: Finish adding Postgres Integration to Analytics Library #45

acouch opened this issue May 20, 2024 · 4 comments · Fixed by #72

Comments

@acouch
Copy link
Member

acouch commented May 20, 2024

Summary

This PR HHS#1938 fulfills https://github.com/HHS/simpler-grants-gov/issue/1599. It looks like it has the client connection, but not the correct connection strings, but I could be reading https://github.com/HHS/simpler-grants-gov/pull/1938/files#diff-d3a30f2861a59952acf2885eea223b8d5a8423b8c2e0449edd39198b0923a4edR21 incorrectly and that works.

This task is to finish that and merge it into our repo.

Acceptance criteria

  • analytics libray can connect to the analytics db
  • tests coverage is added
  • tests pass
@aplybeah aplybeah self-assigned this May 20, 2024
@aplybeah
Copy link

Update:
Had some time to sync with @acouch about implementation strategies/local testing

@aplybeah
Copy link

aplybeah commented Jun 5, 2024

Update:
Noticed that in analytics/config.py there was a reference to a settings.toml. I've been experiementing with setting some of the database config in here, but I have been struggling to follow where some of the overrides happen. Additionally, I wanted to find a way to create the connections without hardcoding too much

@aplybeah aplybeah mentioned this issue Jun 6, 2024
Merged
@aplybeah
Copy link

aplybeah commented Jun 7, 2024

Update: working on accessing the env vars so that the database url can be created without hardcoding secrets (e.g. database password)

@aplybeah aplybeah mentioned this issue Jun 7, 2024
Closed
aplybeah added a commit that referenced this issue Jun 12, 2024
@aplybeah
[Task]: Finish adding Postgres Integration to Analytics Library (#72)
ddf0d75 
## Summary
Fixes #45 

### Time to review: __3 mins__

## Changes proposed
* update `config.py` database url
* add function in `cli.py` 
* updated packages in `poetry.lock`

## Context for reviewers
N/A

## Additional information
Row created manually in the database alongside a row created via
`test_connection`
![Screen Shot 2024-06-11 at 1 49 53
PM](https://github.com/navapbc/simpler-grants-gov/assets/37313082/b83afad8-5fe1-404f-adf3-c94945740bbe)
@acouch acouch mentioned this issue Sep 17, 2024
Closed
3 tasks
@acouch
Copy link
Member Author

acouch commented Sep 17, 2024

Issue migrated to HHS#2080

@acouch acouch removed the Migrated label Sep 17, 2024
acouch pushed a commit that referenced this issue Sep 18, 2024
@aplybeah @acouch
[Task]: Finish adding Postgres Integration to Analytics Library (#72)
1055985 
Fixes #45

* update `config.py` database url
* add function in `cli.py`
* updated packages in `poetry.lock`

N/A

Row created manually in the database alongside a row created via
`test_connection`
![Screen Shot 2024-06-11 at 1 49 53
PM](https://github.com/navapbc/simpler-grants-gov/assets/37313082/b83afad8-5fe1-404f-adf3-c94945740bbe)
acouch pushed a commit that referenced this issue Sep 18, 2024
@aplybeah @acouch
[Task]: Finish adding Postgres Integration to Analytics Library (#72)
d1ee9f1 
Fixes #45

* update `config.py` database url
* add function in `cli.py`
* updated packages in `poetry.lock`

N/A

Row created manually in the database alongside a row created via
`test_connection`
![Screen Shot 2024-06-11 at 1 49 53
PM](https://github.com/navapbc/simpler-grants-gov/assets/37313082/b83afad8-5fe1-404f-adf3-c94945740bbe)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Task]: Finish adding Postgres Integration to Analytics Library navapbc/simpler-grants-gov
2 participants
@acouch @aplybeah