-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[teamd]: Downgrade supervisord (python3->python2) to overcome LAG cleanup degradation #24
Conversation
…anup degradation. Signed-off-by: Nazarii Hnydyn <nazariig@nvidia.com>
# W/A: setuptools and wheel are necessary for installing some Python wheel packages | ||
RUN pip2 install --no-cache-dir setuptools==44.1.1 | ||
RUN pip2 install --no-cache-dir wheel==0.35.1 | ||
|
||
# W/A: install supervisor | ||
RUN pip2 install supervisor==4.2.1 | ||
|
||
# W/A: add support for supervisord to handle startup dependencies | ||
RUN pip2 install supervisord-dependent-startup==1.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we combine into single RUN instruction to reduce build time?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@stepanblyschak this pattern has been taken from the original Makefile and it has some logical blocks separation. Not sure if we can gain much performance from combining install steps.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It does make a difference: https://github.com/Azure/SONiC/blob/master/doc/sonic-build-system/build_system_improvements.md#improving-dockerfile-instructions.
We do not gain anything from seperate RUN instructions since cache is disabled.
ce72b0d Longxiang Lyu Thu Feb 24 06:05:12 2022 Put handler member functions as virtual in base (#30) ef59e4f Jing Zhang Fri Feb 25 11:38:28 2022 Incrementing tolerance on mux state inconsistency (#27) 2d12892 Longxiang Lyu Wed Feb 16 03:32:06 2022 Rename LinkManagerStateMachine to ActiveStandbyStateMachine (#26) f38634c Jing Zhang Thu Feb 17 17:23:56 2022 Update log level for mux probing and mux state chance (#23) a8434dd Jing Zhang Thu Feb 17 17:21:01 2022 Handle xcvrd crashing scenarios (#22) 2ebdb2b Longxiang Lyu Mon Feb 14 13:26:07 2022 [make] Enable make extra includes (#24)
Changes: Update submodule branch to 202012 [sonic-linkmgrd][202012] submodule update a8ddff5 Jing Zhang Fri Feb 25 11:38:28 2022 Incrementing tolerance on mux state inconsistency (#27) a3f78a3 Jing Zhang Thu Feb 17 17:23:56 2022 Update log level for mux probing and mux state chance (#23) 05156fb Jing Zhang Thu Feb 17 17:21:01 2022 Handle xcvrd crashing scenarios (#22) 74529ef Longxiang Lyu Mon Feb 14 13:26:07 2022 [make] Enable make extra includes (#24) sign-off: Jing Zhang zhangjing@microsoft.com
Signed-off-by: Nazarii Hnydyn nazariig@nvidia.com
Why I did it
How I did it
How to verify it
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)