Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single sign out support #64

Merged
merged 6 commits into from
Mar 4, 2013
Merged

Single sign out support #64

merged 6 commits into from
Mar 4, 2013

Conversation

endel
Copy link
Contributor

@endel endel commented Feb 27, 2013

As already discussed on pull request #48, here is my fork of @jeremyhaile's implementation, which works for the session stores:

ActiveRecord::SessionStore
ActionDispatch::Session::CacheStore
RedisStore

@nbudin
Copy link
Owner

nbudin commented Feb 28, 2013

I really like this refactoring. Great work both @jeremyhaile and @endel; once someone has tested it in a real world setup I'd love to get this merged.

@geoffroh
Copy link
Contributor

geoffroh commented Mar 1, 2013

@endel @nbudin This looks good to me, works well on a CAS setup i'm using. Thank you.

@nbudin nbudin merged commit 4120200 into nbudin:master Mar 4, 2013
@nbudin
Copy link
Owner

nbudin commented Mar 4, 2013

Great, thank you everyone! Just merged to master; it passes tests for me locally but I'm waiting to see if it works on Travis before doing a release.

@stephenlam
Copy link

failing on Travis?

@nbudin
Copy link
Owner

nbudin commented Mar 4, 2013

The current Travis results aren't actually with this changeset. It seems like Travis is hung up right now on running new stuff; hopefully it will be back soon.

Even when it does start running these tests, it's likely to come up as an overall failure, because the tests are broken in certain environments (the very oldest versions of Ruby and Rails) and I haven't been able to fix them. (Patches welcome!) But I want to at least see that we're still passing in the environments in which we were before.

@nbudin
Copy link
Owner

nbudin commented Mar 6, 2013

OK, it looks like Travis is still having some issues, but we've got a passing build on recent versions of Devise (which is roughly equivalent to where we were before this pull request). I don't love being in this state, but given that we have a report of it working in practice, and we know that the current implementation has problems in practice, I'm going to release this. Will update here when it's done.

@nbudin
Copy link
Owner

nbudin commented Mar 6, 2013

And it's out. Version 1.2.0, with brand shiny new single sign out support.

Serious, major thanks to everyone who contributed here. This is by far the most opaque part of the project to me, having no easy way to test it, so I really appreciate everyone's work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants